From: Ohad Ben-Cohen <ohad@wizery.com>
To: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
Brian Swetland <swetland@google.com>,
Iliyan Malchev <malchev@google.com>,
Arnd Bergmann <arnd@arndb.de>,
Grant Likely <grant.likely@secretlab.ca>,
Rusty Russell <rusty@rustcorp.com.au>,
Mark Grosen <mgrosen@ti.com>,
John Williams <john.williams@petalogix.com>,
Michal Simek <monstr@monstr.eu>,
Loic PALLARDY <loic.pallardy@stericsson.com>,
Ludovic BARRE <ludovic.barre@stericsson.com>,
Omar Ramirez Luna <omar.luna@linaro.org>,
Guzman Lugo Fernando <fernando.lugo@ti.com>,
Anna Suman <s-anna@ti.com>, Clark Rob <rob@ti.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Saravana Kannan <skannan@codeaurora.org>,
David Brown <davidb@codeaurora.org>,
Kieran Bingham <kieranbingham@gmail.com>,
Tony Lindgren <tony@atomide.com>
Subject: [PATCH 5/7] remoteproc/omap: remove the mbox_callback limitation
Date: Thu, 1 Mar 2012 10:11:35 +0200 [thread overview]
Message-ID: <1330589497-4139-6-git-send-email-ohad@wizery.com> (raw)
In-Reply-To: <1330589497-4139-1-git-send-email-ohad@wizery.com>
Now that remoteproc supports any number of virtio devices,
the previous sanity check in omap_rproc_mbox_callback
doesn't make sense anymore.
Remove that so we can start supporting multiple vdevs.
Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
Cc: Brian Swetland <swetland@google.com>
Cc: Iliyan Malchev <malchev@google.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Cc: Mark Grosen <mgrosen@ti.com>
Cc: John Williams <john.williams@petalogix.com>
Cc: Michal Simek <monstr@monstr.eu>
Cc: Loic PALLARDY <loic.pallardy@stericsson.com>
Cc: Ludovic BARRE <ludovic.barre@stericsson.com>
Cc: Omar Ramirez Luna <omar.luna@linaro.org>
Cc: Guzman Lugo Fernando <fernando.lugo@ti.com>
Cc: Anna Suman <s-anna@ti.com>
Cc: Clark Rob <rob@ti.com>
Cc: Stephen Boyd <sboyd@codeaurora.org>
Cc: Saravana Kannan <skannan@codeaurora.org>
Cc: David Brown <davidb@codeaurora.org>
Cc: Kieran Bingham <kieranbingham@gmail.com>
Cc: Tony Lindgren <tony@atomide.com>
---
drivers/remoteproc/omap_remoteproc.c | 11 +----------
1 files changed, 1 insertions(+), 10 deletions(-)
diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c
index aa3ce52..69425c4 100644
--- a/drivers/remoteproc/omap_remoteproc.c
+++ b/drivers/remoteproc/omap_remoteproc.c
@@ -80,16 +80,7 @@ static int omap_rproc_mbox_callback(struct notifier_block *this,
dev_info(dev, "received echo reply from %s\n", name);
break;
default:
- /* ignore vq indices which are too large to be valid */
- if (msg >= 2) {
- dev_warn(dev, "invalid mbox msg: 0x%x\n", msg);
- break;
- }
-
- /*
- * At this point, 'msg' contains the index of the vring
- * which was just triggered.
- */
+ /* msg contains the index of the triggered vring */
if (rproc_vq_interrupt(oproc->rproc, msg) == IRQ_NONE)
dev_dbg(dev, "no message was found in vqid %d\n", msg);
}
--
1.7.5.4
next prev parent reply other threads:[~2012-03-01 8:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 8:11 [PATCH 0/7] remoteproc: additional virtio support Ohad Ben-Cohen
2012-03-01 8:11 ` [PATCH 1/7] remoteproc: resource table overhaul Ohad Ben-Cohen
2012-03-16 14:57 ` Michal Simek
2012-03-17 6:39 ` Ohad Ben-Cohen
2012-03-19 7:07 ` Michal Simek
2012-05-17 18:45 ` Ohad Ben-Cohen
2012-05-21 13:02 ` Michal Simek
2012-05-21 14:00 ` Ohad Ben-Cohen
2012-05-22 5:51 ` Michal Simek
2012-05-22 8:02 ` Ohad Ben-Cohen
2012-05-22 8:18 ` Michal Simek
2012-05-22 9:14 ` frq09524
2012-05-22 9:22 ` Ohad Ben-Cohen
2012-05-22 12:51 ` frq09524
2012-05-23 12:41 ` Ohad Ben-Cohen
2012-03-01 8:11 ` [PATCH 2/7] remoteproc: remoteproc_rpmsg -> remoteproc_virtio Ohad Ben-Cohen
2012-03-01 8:11 ` [PATCH 3/7] remoteproc: safer boot/shutdown order Ohad Ben-Cohen
2012-03-01 8:11 ` [PATCH 4/7] remoteproc: remove the single rpmsg vdev limitation Ohad Ben-Cohen
2012-03-01 8:11 ` Ohad Ben-Cohen [this message]
2012-03-01 8:11 ` [PATCH 6/7] remoteproc: remove the hardcoded vring alignment Ohad Ben-Cohen
2012-03-01 8:11 ` [PATCH 7/7] remoteproc: cleanup resource table parsing paths Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330589497-4139-6-git-send-email-ohad@wizery.com \
--to=ohad@wizery.com \
--cc=arnd@arndb.de \
--cc=davidb@codeaurora.org \
--cc=fernando.lugo@ti.com \
--cc=grant.likely@secretlab.ca \
--cc=john.williams@petalogix.com \
--cc=kieranbingham@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=loic.pallardy@stericsson.com \
--cc=ludovic.barre@stericsson.com \
--cc=malchev@google.com \
--cc=mgrosen@ti.com \
--cc=monstr@monstr.eu \
--cc=omar.luna@linaro.org \
--cc=rob@ti.com \
--cc=rusty@rustcorp.com.au \
--cc=s-anna@ti.com \
--cc=sboyd@codeaurora.org \
--cc=skannan@codeaurora.org \
--cc=swetland@google.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).