From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ohad Ben-Cohen Subject: [PATCH 5/7] remoteproc/omap: remove the mbox_callback limitation Date: Thu, 1 Mar 2012 10:11:35 +0200 Message-ID: <1330589497-4139-6-git-send-email-ohad@wizery.com> References: <1330589497-4139-1-git-send-email-ohad@wizery.com> Mime-Version: 1.0 Return-path: In-Reply-To: <1330589497-4139-1-git-send-email-ohad@wizery.com> Sender: linux-kernel-owner@vger.kernel.org To: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Ohad Ben-Cohen , Brian Swetland , Iliyan Malchev , Arnd Bergmann , Grant Likely , Rusty Russell , Mark Grosen , John Williams , Michal Simek , Loic PALLARDY , Ludovic BARRE , Omar Ramirez Luna , Guzman Lugo Fernando , Anna Suman , Clark Rob , Stephen Boyd , Saravana Kannan , David Brown , Kieran Bingham , Tony Lindgren List-Id: linux-omap@vger.kernel.org Now that remoteproc supports any number of virtio devices, the previous sanity check in omap_rproc_mbox_callback doesn't make sense anymore. Remove that so we can start supporting multiple vdevs. Signed-off-by: Ohad Ben-Cohen Cc: Brian Swetland Cc: Iliyan Malchev Cc: Arnd Bergmann Cc: Grant Likely Cc: Rusty Russell Cc: Mark Grosen Cc: John Williams Cc: Michal Simek Cc: Loic PALLARDY Cc: Ludovic BARRE Cc: Omar Ramirez Luna Cc: Guzman Lugo Fernando Cc: Anna Suman Cc: Clark Rob Cc: Stephen Boyd Cc: Saravana Kannan Cc: David Brown Cc: Kieran Bingham Cc: Tony Lindgren --- drivers/remoteproc/omap_remoteproc.c | 11 +---------- 1 files changed, 1 insertions(+), 10 deletions(-) diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c index aa3ce52..69425c4 100644 --- a/drivers/remoteproc/omap_remoteproc.c +++ b/drivers/remoteproc/omap_remoteproc.c @@ -80,16 +80,7 @@ static int omap_rproc_mbox_callback(struct notifier_block *this, dev_info(dev, "received echo reply from %s\n", name); break; default: - /* ignore vq indices which are too large to be valid */ - if (msg >= 2) { - dev_warn(dev, "invalid mbox msg: 0x%x\n", msg); - break; - } - - /* - * At this point, 'msg' contains the index of the vring - * which was just triggered. - */ + /* msg contains the index of the triggered vring */ if (rproc_vq_interrupt(oproc->rproc, msg) == IRQ_NONE) dev_dbg(dev, "no message was found in vqid %d\n", msg); } -- 1.7.5.4