From: Kishon Vijay Abraham I <kishon@ti.com>
To: balbi@ti.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, stable@vger.kernel.org,
linux-omap@vger.kernel.org
Cc: kishon@ti.com
Subject: [PATCH RESEND] usb: musb: omap: fix crash when musb glue (omap) gets initialized
Date: Thu, 22 Mar 2012 16:05:45 +0530 [thread overview]
Message-ID: <1332412545-32396-1-git-send-email-kishon@ti.com> (raw)
Upstream Commit: 7acc6197b76edd0b932a7cbcc6cfad0a8a87f026
Upstream Kernel Tag: v2.6.38-rc5-94-g7acc619
pm_runtime_enable is being called after omap2430_musb_init. Hence
pm_runtime_get_sync in omap2430_musb_init does not have any effect (does
not enable clocks) resulting in a crash during register access. It is
fixed here.
Cc: stable@vger.kernel.org
Cc: Felipe Balbi <balbi@ti.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
Tested MUSB in 4430SDP.
drivers/usb/musb/omap2430.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
index 2ae0bb3..73bd5ed 100644
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -452,14 +452,14 @@ static int __devinit omap2430_probe(struct platform_device *pdev)
goto err2;
}
+ pm_runtime_enable(&pdev->dev);
+
ret = platform_device_add(musb);
if (ret) {
dev_err(&pdev->dev, "failed to register musb device\n");
goto err2;
}
- pm_runtime_enable(&pdev->dev);
-
return 0;
err2:
--
1.7.0.4
next reply other threads:[~2012-03-22 10:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-22 10:35 Kishon Vijay Abraham I [this message]
2012-03-22 14:33 ` [PATCH RESEND] usb: musb: omap: fix crash when musb glue (omap) gets initialized Greg KH
2012-03-22 21:34 ` ABRAHAM, KISHON VIJAY
2012-03-22 21:39 ` Greg KH
[not found] ` <20120322213918.GA11352-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2012-03-22 22:29 ` ABRAHAM, KISHON VIJAY
2012-03-22 22:34 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1332412545-32396-1-git-send-email-kishon@ti.com \
--to=kishon@ti.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox