Re: [PATCH 1/3] OMAPDSS: HDMI: support for interrupt enabling

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1496 bytes --]

On Tue, 2012-03-20 at 18:45 +0530, mythripk@ti.com wrote:
> From: Mythri P K <mythripk@ti.com>
> 
> Add function to enable or clear interrupts in the HDMI wrapper.
> 
> Signed-off-by: Mythri P K <mythripk@ti.com>
> ---
>  drivers/video/omap2/dss/ti_hdmi.h         |   16 ++++++++++
>  drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c |   45 +++++++++++++++++++++++++++++
>  drivers/video/omap2/dss/ti_hdmi_4xxx_ip.h |    1 +
>  3 files changed, 62 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/video/omap2/dss/ti_hdmi.h b/drivers/video/omap2/dss/ti_hdmi.h
> index 1f58b84..6d65b3b 100644
> --- a/drivers/video/omap2/dss/ti_hdmi.h
> +++ b/drivers/video/omap2/dss/ti_hdmi.h
> @@ -80,6 +80,22 @@ struct hdmi_pll_info {
>  	enum hdmi_clk_refsel refsel;
>  };
>  
> +struct hdmi_irq_vector {
> +	u8	pll_recal;
> +	u8	pll_unlock;
> +	u8	pll_lock;
> +	u8	phy_disconnect;
> +	u8	phy_connect;
> +	u8	phy_short_5v;
> +	u8	video_end_fr;
> +	u8	video_vsync;
> +	u8	fifo_sample_req;
> +	u8	fifo_overflow;
> +	u8	fifo_underflow;
> +	u8	ocp_timeout;
> +	u8	core;
> +};

This feels like a very complex way to do a simple thing... Why is this
in ti_hdmi.h anyway? These are omap4 HDMI interrupts, right?

Why don't you just define the interrupts the same way dispc/dsi do:

#define HDMI_IRQ_RECAL (1 << 31)

Then you could have simple functions like hdmi_enable_irq(u32 irqmask)
and call it like:

hdmi_enable_irq(HDMI_IRQ_RECAL | HDMI_IRQ_SOMETHING);

 Tomi


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]