From: Rajendra Nayak <rnayak@ti.com>
To: paul@pwsan.com, b-cousson@ti.com
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Rajendra Nayak <rnayak@ti.com>
Subject: [PATCH] ARM: omap: hwmod: warn only when clkdm is missing from both clk and hwmod
Date: Thu, 12 Apr 2012 19:11:38 +0530 [thread overview]
Message-ID: <1334238098-29859-1-git-send-email-rnayak@ti.com> (raw)
On OMAP4+, the clkdm association is moved to hwmod while on older OMAPs'
its associated with a clk.
Hence look for a clkdm in both clk and hwmod and warn only when
its missing in both. Also fix the pr_warning() to print the correct
hwmod name.
Signed-off-by: Rajendra Nayak <rnayak@ti.com>
---
arch/arm/mach-omap2/omap_hwmod.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
index 2c27fdb..83d56df 100644
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -566,9 +566,9 @@ static int _init_main_clk(struct omap_hwmod *oh)
return -EINVAL;
}
- if (!oh->_clk->clkdm)
+ if (!oh->_clk->clkdm && !oh->clkdm_name)
pr_warning("omap_hwmod: %s: missing clockdomain for %s.\n",
- oh->main_clk, oh->_clk->name);
+ oh->name, oh->_clk->name);
return ret;
}
--
1.7.1
next reply other threads:[~2012-04-12 13:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-12 13:41 Rajendra Nayak [this message]
2012-04-12 17:06 ` [PATCH] ARM: omap: hwmod: warn only when clkdm is missing from both clk and hwmod Paul Walmsley
2012-04-18 8:09 ` Cousson, Benoit
2012-04-18 8:52 ` Paul Walmsley
2012-04-18 9:08 ` Paul Walmsley
2012-04-18 9:09 ` Cousson, Benoit
2012-04-18 9:40 ` Paul Walmsley
2012-04-18 9:57 ` Cousson, Benoit
2012-04-18 10:12 ` Paul Walmsley
2012-04-18 10:29 ` Cousson, Benoit
2012-04-18 10:53 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1334238098-29859-1-git-send-email-rnayak@ti.com \
--to=rnayak@ti.com \
--cc=b-cousson@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox