From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Hein Tibosch <hein_tibosch@yahoo.es>
Cc: linux-omap <linux-omap@vger.kernel.org>
Subject: Re: omapfb-main.c: check result of simple_strtoul
Date: Thu, 10 May 2012 14:02:29 +0300 [thread overview]
Message-ID: <1336647749.5182.36.camel@deskari> (raw)
In-Reply-To: <4FAB9DC1.6000908@yahoo.es>
[-- Attachment #1: Type: text/plain, Size: 1167 bytes --]
On Thu, 2012-05-10 at 18:51 +0800, Hein Tibosch wrote:
> On 5/10/2012 4:23 PM, Tomi Valkeinen wrote:
> > On Wed, 2012-05-09 at 22:47 +0800, Hein Tibosch wrote:
> >> fbnum = simple_strtoul(p, &p, 10);
> >> - if (p == param)
> >> + if (p == start)
> >>
> >> correct?
> > Yes, looks like a correct fix. I'll cook up a patch.
> >
> > How did you encounter the bug? What was the outcome?
> I was reading the source, adding some printk's to get more debugging.
>
> It would fail to detect a syntax error like:
>
> "omapfb.vram=0:2M,:5M"
>
Ok, thanks.
> If I may ask: why aren't "mode" and "modes" filled in:
>
> /sys/devices/platform/omapfb/graphics/fb0 ?
>
> Only "modes" will get an entry when a new mode becomes active.
No particular reason, nobody just has implemented it.
> I thought of adding something like this in hdmi.c:
>
> +static void omap_to_fbmode (struct fb_videomode *fb_mode, const struct hdmi_config *cfg)
> +{
You can't add framebuffer code to omapdss. omapdss is the lowlevel
driver that cannot depend on the fb driver. omapdss is also used by
other display drivers like omapdrm.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-05-10 11:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 14:47 omapfb-main.c: check result of simple_strtoul Hein Tibosch
2012-05-10 8:23 ` Tomi Valkeinen
2012-05-10 10:51 ` Hein Tibosch
2012-05-10 11:02 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336647749.5182.36.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=hein_tibosch@yahoo.es \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox