Re: [PATCH] OMAP: Beagle: fix DVI GPIO request

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1688 bytes --]

On Mon, 2012-05-21 at 12:59 +0200, Koen Kooi wrote:
> Op 21 mei 2012, om 11:41 heeft Tomi Valkeinen het volgende geschreven:
> 
> > Commit e813a55eb9c9bc6c8039fb16332cf43402125b30 ("OMAP: board-files:
> > remove custom PD GPIO handling for DVI output") moved TFP410 chip's
> > powerdown-gpio handling from the board files to the tfp410 driver. One
> > gpio_request_one(powerdown-gpio, ...) was mistakenly left unremoved in
> > the Beagle board file. This causes the tfp410 driver to fail to request
> > the gpio on Beagle, causing the driver to fail and thus the DVI output
> > doesn't work.
> > 
> > This patch removes the gpio_request_one() from the board file.
> > 
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > ---
> > arch/arm/mach-omap2/board-omap3beagle.c |    3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> > index 8ede8d2..72ad1f6 100644
> > --- a/arch/arm/mach-omap2/board-omap3beagle.c
> > +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> > @@ -510,9 +510,8 @@ static void __init omap3_beagle_init(void)
> > 	omap_sdrc_init(mt46h32m32lf6_sdrc_params,
> > 				  mt46h32m32lf6_sdrc_params);
> > 
> > +	/* DVI power down GPIO */
> > 	omap_mux_init_gpio(170, OMAP_PIN_INPUT);
> 
> Wouldn't it be an output rather than an input?

Indeed. Note that I didn't change the line above =).

It seems this was changed last December:

-       omap_cfg_reg(J25_34XX_GPIO170);
+       omap_mux_init_gpio(170, OMAP_PIN_INPUT);

I wonder if the mux init is even necessary. Shouldn't the bootloader set
the muxes?

 Tomi


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]