[PATCH] OMAPDSS: HDMI: OMAP4: Fix request_irq for HPD

[PATCH] OMAPDSS: HDMI: OMAP4: Fix request_irq for HPD

[Ricardo Neri]

Hi Tomi,

While validating HDMI audio on the linux-next tree I found that requesting
the threaded irq for HDMI HDP will fail due to an upcoming change in genirq[1].
This change requires to use the IRQF_ONESHOT flag even for edge type interrupts
if no handler is provided, otherwise the request will fail.

Also, while there, I removed the IRQF_DISABLED flag as it is now deprecated.

If you are OK with the change, I hope it could be merged for K3.5 otherwise
HDMI will fail.

[1].http://www.spinics.net/lists/linux-tip-commits/msg14974.html

Ricardo Neri (1):
  OMAPDSS: HDMI: OMAP4: Update IRQ flags for the HPD IRQ request

 drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

-- 
1.7.5.4

[PATCH] OMAPDSS: HDMI: OMAP4: Update IRQ flags for the HPD IRQ request

[Ricardo Neri]

genirq requires that the IRQ requests that do not provided a handler to
use the IRQF_ONESHOT flag. This is to prevent situations in which the irq line
is reenabled while the interrupt is still asserted. While this situation may
not happen in edge type interrupts, genirq still requires to use IRQF_ONESHOT.

Also, remove the IRQF_DISABLED as the flag is now a NOOP and has been
deprecated.

Signed-off-by: Ricardo Neri <ricardo.neri@ti.com>
---
 drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c b/drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c
index 4dcdbbb..d52823d 100644
--- a/drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c
+++ b/drivers/video/omap2/dss/ti_hdmi_4xxx_ip.c
@@ -303,9 +303,9 @@ int ti_hdmi_4xxx_phy_enable(struct hdmi_ip_data *ip_data)
 	REG_FLD_MOD(phy_base, HDMI_TXPHY_PAD_CFG_CTRL, 0x1, 27, 27);
 
 	r = request_threaded_irq(gpio_to_irq(ip_data->hpd_gpio),
-			NULL, hpd_irq_handler,
-			IRQF_DISABLED | IRQF_TRIGGER_RISING |
-			IRQF_TRIGGER_FALLING, "hpd", ip_data);
+				 NULL, hpd_irq_handler,
+				 IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING |
+				 IRQF_ONESHOT, "hpd", ip_data);
 	if (r) {
 		DSSERR("HPD IRQ request failed\n");
 		hdmi_set_phy_pwr(ip_data, HDMI_PHYPWRCMD_OFF);
-- 
1.7.5.4

Re: [PATCH] OMAPDSS: HDMI: OMAP4: Update IRQ flags for the HPD IRQ request

[Tomi Valkeinen]

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]

On Mon, 2012-05-21 at 21:47 -0500, Ricardo Neri wrote:
> genirq requires that the IRQ requests that do not provided a handler to
> use the IRQF_ONESHOT flag. This is to prevent situations in which the irq line
> is reenabled while the interrupt is still asserted. While this situation may
> not happen in edge type interrupts, genirq still requires to use IRQF_ONESHOT.
> 
> Also, remove the IRQF_DISABLED as the flag is now a NOOP and has been
> deprecated.

Thanks, I'll apply.

 Tomi


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]