Re: [PATCH] OMAP: Beagle: fix TFP410 powerdown GPIO init

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]

On Wed, 2012-06-13 at 23:58 -0700, Russ Dill wrote:
> On Wed, Jun 13, 2012 at 2:20 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> > Commit e813a55eb9c9bc6c8039fb16332cf43402125b30 ("OMAP: board-files:
> > remove custom PD GPIO handling for DVI output") moved TFP410 chip's
> > powerdown-gpio handling from the board files to the tfp410 driver. One
> > gpio_request_one(powerdown-gpio, ...) was mistakenly left unremoved in
> > the Beagle board file. This causes the tfp410 driver to fail to request
> > the gpio on Beagle, causing the driver to fail and thus the DVI output
> > doesn't work.
> 
> Can you take the one I sent earlier instead?
> 
> http://www.spinics.net/lists/linux-omap/msg69913.html

Hmm, that probably doesn't apply. The power-down GPIO is now handled in
the tfp410 driver, not in the board files.

Looking more closely at the board file, what are these nDVI_PWR_EN,
DVI_LDO_EN and DVI_PU gpios? There's no "enable line" on tfp410. Only
the power-down gpio, which is none of the above...

 Tomi


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]