Re: [PATCH] OMAP: Beagle: fix TFP410 powerdown GPIO init

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1718 bytes --]

On Thu, 2012-06-14 at 04:40 -0700, Russ Dill wrote:
> On Thu, Jun 14, 2012 at 1:13 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> > On Thu, 2012-06-14 at 00:59 -0700, Russ Dill wrote:
> >> On Thu, Jun 14, 2012 at 12:18 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> >> > On Wed, 2012-06-13 at 23:58 -0700, Russ Dill wrote:
> >> >> On Wed, Jun 13, 2012 at 2:20 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> >> >> > Commit e813a55eb9c9bc6c8039fb16332cf43402125b30 ("OMAP: board-files:
> >> >> > remove custom PD GPIO handling for DVI output") moved TFP410 chip's
> >> >> > powerdown-gpio handling from the board files to the tfp410 driver. One
> >> >> > gpio_request_one(powerdown-gpio, ...) was mistakenly left unremoved in
> >> >> > the Beagle board file. This causes the tfp410 driver to fail to request
> >> >> > the gpio on Beagle, causing the driver to fail and thus the DVI output
> >> >> > doesn't work.
> >> >>
> >> >> Can you take the one I sent earlier instead?
> >> >>
> >> >> http://www.spinics.net/lists/linux-omap/msg69913.html
> >> >
> >> > Hmm, that probably doesn't apply. The power-down GPIO is now handled in
> >> > the tfp410 driver, not in the board files.
> >>
> >> Give me a branch to rebase it onto and I will.
> >
> > v3.5-rc2
> 
> This one (v4) already applies to v3.5-rc2
> 
> http://www.spinics.net/lists/linux-omap/msg70042.html

My ack for v4:

Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>

And I'd reword the description, "fix" instead of cleanup. The "boot
warnings" are errors. I don't think the DVI output works at all with
beagle in the current mainline.

Btw, please cc me when sending patches related to display.

 Tomi


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]