From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Rob Clark <rob.clark@linaro.org>
Cc: dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org,
patches@linaro.org, Greg KH <greg@kroah.com>,
Andy Gross <andy.gross@ti.com>,
cmahapatra@ti.com, s-guiriec@ti.com, archit@ti.com,
Rob Clark <rob@ti.com>
Subject: Re: [PATCH] staging: drm/omap: add rotation properties
Date: Fri, 29 Jun 2012 13:46:03 +0300 [thread overview]
Message-ID: <1340966763.2767.8.camel@deskari> (raw)
In-Reply-To: <1340805986-10670-1-git-send-email-rob.clark@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 794 bytes --]
On Wed, 2012-06-27 at 09:06 -0500, Rob Clark wrote:
> From: Rob Clark <rob@ti.com>
>
> Use tiled buffers for rotated/reflected scanout, with CRTC and plane
> properties as the interface for userspace to configure rotation.
>
> Signed-off-by: Rob Clark <rob@ti.com>
> +/* this should probably be in drm-core to standardize amongst drivers */
> +#define DRM_ROTATE_0 0
> +#define DRM_ROTATE_90 1
> +#define DRM_ROTATE_180 2
> +#define DRM_ROTATE_270 3
> +#define DRM_REFLECT_X 4
> +#define DRM_REFLECT_Y 5
Are both reflect X and Y needed? You can get all the possible
orientations with just one of the reflects.
And I think the word "mirror" represents nicely what the reflect does,
i.e. if you look at the mirror, the image you see is flipped
horizontally.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-06-29 10:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 14:06 [PATCH] staging: drm/omap: add rotation properties Rob Clark
2012-06-27 14:09 ` Rob Clark
2012-06-27 19:40 ` Greg KH
2012-06-27 20:02 ` Rob Clark
2012-06-29 10:46 ` Tomi Valkeinen [this message]
2012-06-29 12:17 ` Rob Clark
2012-07-02 14:01 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1340966763.2767.8.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=andy.gross@ti.com \
--cc=archit@ti.com \
--cc=cmahapatra@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=greg@kroah.com \
--cc=linux-omap@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rob.clark@linaro.org \
--cc=rob@ti.com \
--cc=s-guiriec@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).