From: Felipe Balbi <balbi@ti.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>,
Felipe Balbi <balbi@ti.com>
Subject: [PATCH 4/5] arm: omap: debug-leds: add a remove method
Date: Tue, 24 Jul 2012 11:54:01 +0300 [thread overview]
Message-ID: <1343120042-16695-5-git-send-email-balbi@ti.com> (raw)
In-Reply-To: <1343120042-16695-1-git-send-email-balbi@ti.com>
while at that, also convert to module_platform_driver
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
arch/arm/plat-omap/debug-leds.c | 25 ++++++++++++++++++++-----
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/arch/arm/plat-omap/debug-leds.c b/arch/arm/plat-omap/debug-leds.c
index 392daa8..08fbb85 100644
--- a/arch/arm/plat-omap/debug-leds.c
+++ b/arch/arm/plat-omap/debug-leds.c
@@ -251,6 +251,14 @@ static void __devinit newled_init(struct device *dev)
return;
}
+static void __devexit newled_exit(void)
+{
+ unsigned i;
+ struct dbg_led *led;
+
+ for (i = 0, led = dbg_leds; i < ARRAY_SIZE(dbg_leds); i++, led++)
+ led_classdev_unregister(&led->cdev);
+}
/*-------------------------------------------------------------------------*/
@@ -279,6 +287,16 @@ static int __devinit fpga_probe(struct platform_device *pdev)
return 0;
}
+static int __devexit fpga_remove(struct platform_device *pdev)
+{
+ if (new_led_api())
+ newled_exit();
+
+ iounmap(fpga);
+
+ return 0;
+}
+
static int fpga_suspend_noirq(struct device *dev)
{
__raw_writew(~0, &fpga->leds);
@@ -300,10 +318,7 @@ static struct platform_driver led_driver = {
.driver.name = "omap_dbg_led",
.driver.pm = &fpga_dev_pm_ops,
.probe = fpga_probe,
+ .remove = __devexit_p(fpga_remove),
};
-static int __init fpga_init(void)
-{
- return platform_driver_register(&led_driver);
-}
-module_init(fpga_init);
+module_platform_driver(led_driver);
--
1.7.11
next prev parent reply other threads:[~2012-07-24 8:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-24 8:53 [PATCH 0/5] arm: omap: debug-leds: few changes Felipe Balbi
2012-07-24 8:53 ` [PATCH 1/5] arm: omap: debug-leds: drop machine_is_* checks Felipe Balbi
2012-07-24 8:53 ` [PATCH 2/5] arm: omap: debug-leds: move initialization to debug-leds Felipe Balbi
2012-07-24 8:54 ` [PATCH 3/5] arm: omap: debug-leds: add section annotation to probe Felipe Balbi
2012-07-24 8:54 ` Felipe Balbi [this message]
2012-07-24 8:54 ` [PATCH 5/5] arm: omap: debug-leds: switch to resource_size() Felipe Balbi
2012-09-07 22:32 ` [PATCH 0/5] arm: omap: debug-leds: few changes Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343120042-16695-5-git-send-email-balbi@ti.com \
--to=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).