From: Felipe Balbi <balbi@ti.com>
To: zbr@ioremap.net
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Felipe Balbi <balbi@ti.com>
Subject: [PATCH 2/6] w1: omap-hdq: don't hardcode resource size
Date: Wed, 25 Jul 2012 15:05:28 +0300 [thread overview]
Message-ID: <1343217932-25372-2-git-send-email-balbi@ti.com> (raw)
In-Reply-To: <1343217932-25372-1-git-send-email-balbi@ti.com>
we have the helpful resource_size() macro to
calculate the size of the memory resource for
us, let's use it.
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
drivers/w1/masters/omap_hdq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
index 46e1f6f..404a4de 100644
--- a/drivers/w1/masters/omap_hdq.c
+++ b/drivers/w1/masters/omap_hdq.c
@@ -568,7 +568,7 @@ static int __devinit omap_hdq_probe(struct platform_device *pdev)
goto err_resource;
}
- hdq_data->hdq_base = ioremap(res->start, SZ_4K);
+ hdq_data->hdq_base = ioremap(res->start, resource_size(res));
if (!hdq_data->hdq_base) {
dev_dbg(&pdev->dev, "ioremap failed\n");
ret = -EINVAL;
--
1.7.11
next prev parent reply other threads:[~2012-07-25 12:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 12:05 [PATCH 1/6] w1: omap-hdq: add section annotation to remove Felipe Balbi
2012-07-25 12:05 ` Felipe Balbi [this message]
2012-07-25 12:05 ` [PATCH 3/6] w1: omap-hdq: convert to module_platform_driver Felipe Balbi
2012-07-25 12:05 ` [PATCH 4/6] w1: omap-hdq: convert to devm_* functions Felipe Balbi
2012-07-25 12:05 ` [PATCH 5/6] w1: omap-hdq: remove unnecessary return Felipe Balbi
2012-07-25 12:05 ` [PATCH 6/6] w1: omap-hdq: drop ARCH dependency Felipe Balbi
2012-07-26 14:45 ` [PATCH 1/6] w1: omap-hdq: add section annotation to remove Evgeniy Polyakov
2012-07-27 7:04 ` Felipe Balbi
2012-07-31 23:19 ` Evgeniy Polyakov
2012-07-31 23:26 ` Greg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343217932-25372-2-git-send-email-balbi@ti.com \
--to=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).