From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Ricardo Neri <ricardo.neri@ti.com>
Cc: archit@ti.com, s-guiriec@ti.com, linux-omap@vger.kernel.org
Subject: Re: [PATCH v4] OMAPDSS: DISPC: Improvements to DIGIT sync signal selection
Date: Thu, 02 Aug 2012 10:48:27 +0300 [thread overview]
Message-ID: <1343893707.2686.3.camel@deskari> (raw)
In-Reply-To: <1343825800-6971-1-git-send-email-ricardo.neri@ti.com>
[-- Attachment #1: Type: text/plain, Size: 699 bytes --]
On Wed, 2012-08-01 at 07:56 -0500, Ricardo Neri wrote:
> DSS code wrongly assumes that VENC is always available as source for the external
> sync signal for the display controller DIGIT channel. One cannot blindly write/read
> the value of DSS_CONTROL[15] as in certain processors (e.g., OMAP5) this operation
> may not be valid. If the the sync source is not read correctly, the callers of
> dss_get_hdmi_venc_clk_source might make wrong assumptions about, for instance,
> video timings.
>
> Logic is added to correctly get the sync signal based on the available displays
> in the DIGIT channel. The source is set only if both VENC and HDMI are supported.
Thanks, applied.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-08-02 7:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 12:56 [PATCH v4] OMAPDSS: DISPC: Improvements to DIGIT sync signal selection Ricardo Neri
2012-08-02 7:48 ` Tomi Valkeinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343893707.2686.3.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=archit@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=ricardo.neri@ti.com \
--cc=s-guiriec@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox