From: Peter Meerwald <pmeerw@pmeerw.net>
To: Felipe Balbi <balbi@ti.com>
Cc: linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
kishon@ti.com, Peter Meerwald <pmeerw@pmeerw.net>
Subject: [PATCH v2] usb otg: TWL4030_USB to depend on USB_MUSB_OMAP2PLUS in Kconfig
Date: Fri, 24 Aug 2012 11:09:23 +0200 [thread overview]
Message-ID: <1345799363-28199-1-git-send-email-pmeerw@pmeerw.net> (raw)
In-Reply-To: <20120824072729.GE3334@arwen.pp.htv.fi>
3.6-rc2 fails to compile with
CONFIG_USB_MUSB_HDRC=m
CONFIG_USB_MUSB_OMAP2PLUS=m
CONFIG_TWL4030_USB=y
LD init/built-in.o
drivers/built-in.o: In function `twl4030_usb_irq':
/home/pmeerw/linux-3.6-rc2/drivers/usb/otg/twl4030-usb.c:518: undefined reference to `omap_musb_mailbox'
drivers/built-in.o: In function `twl4030_usb_phy_init':
/home/pmeerw/linux-3.6-rc2/drivers/usb/otg/twl4030-usb.c:540: undefined reference to `omap_musb_mailbox'
twl4030-usb uses a symbol from omap2430, hence it should depend on it
Signed-off-by: Peter Meerwald <pmeerw@pmeerw.net>
---
drivers/usb/otg/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/otg/Kconfig b/drivers/usb/otg/Kconfig
index 13fd1ddf..fefca18 100644
--- a/drivers/usb/otg/Kconfig
+++ b/drivers/usb/otg/Kconfig
@@ -58,7 +58,7 @@ config USB_ULPI_VIEWPORT
config TWL4030_USB
tristate "TWL4030 USB Transceiver Driver"
- depends on TWL4030_CORE && REGULATOR_TWL4030
+ depends on TWL4030_CORE && REGULATOR_TWL4030 && USB_MUSB_OMAP2PLUS
select USB_OTG_UTILS
help
Enable this to support the USB OTG transceiver on TWL4030
--
1.7.9.5
next prev parent reply other threads:[~2012-08-24 9:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-18 16:04 linux 3.6-rc2, undefined reference to omap_musb_mailbox Peter Meerwald
2012-08-20 5:36 ` ABRAHAM, KISHON VIJAY
[not found] ` <CAAe_U6+dFuX9fSX_epnPzX_3Zx3XBWAxE6kHDCTeuPwtn-ZQNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-08-20 9:54 ` Felipe Balbi
2012-08-20 10:16 ` ABRAHAM, KISHON VIJAY
2012-08-20 10:26 ` Felipe Balbi
[not found] ` <20120820102641.GM17455-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-08-20 11:07 ` ABRAHAM, KISHON VIJAY
2012-08-20 11:36 ` Felipe Balbi
[not found] ` <20120820113624.GP17455-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-08-23 20:38 ` [PATCH] usb otg: TWL4030_USB depends on USB_MUSB_OMAP2PLUS in Kconfig Peter Meerwald
[not found] ` <1345754324-12068-1-git-send-email-pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>
2012-08-24 7:27 ` Felipe Balbi
2012-08-24 9:09 ` Peter Meerwald [this message]
2012-08-24 10:18 ` ABRAHAM, KISHON VIJAY
2012-08-23 20:38 ` linux 3.6-rc2, undefined reference to omap_musb_mailbox Peter Meerwald
[not found] ` <alpine.DEB.2.01.1208232235200.15831-jW+XmwGofnusTnJN9+BGXg@public.gmane.org>
2012-08-24 7:27 ` Felipe Balbi
[not found] ` <20120824072702.GD3334-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-09-05 14:31 ` Pantelis Antoniou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345799363-28199-1-git-send-email-pmeerw@pmeerw.net \
--to=pmeerw@pmeerw.net \
--cc=balbi@ti.com \
--cc=kishon@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).