From: AnilKumar Ch <anilkumar@ti.com>
To: wg@grandegger.com, mkl@pengutronix.de
Cc: swarren@wwwdotorg.org, linux-can@vger.kernel.org,
linux-omap@vger.kernel.org, anantgole@ti.com, nsekhar@ti.com,
AnilKumar Ch <anilkumar@ti.com>
Subject: [PATCH v3] of: Modify c_can binding documentation
Date: Thu, 6 Sep 2012 15:32:05 +0530 [thread overview]
Message-ID: <1346925725-19873-1-git-send-email-anilkumar@ti.com> (raw)
Modify c_can binding documentation according to recent review comments
on device tree data addition patches.
Signed-off-by: AnilKumar Ch <anilkumar@ti.com>
---
Changes from v2:
- Incorporated Marc's comments on v2
* Fixed typo mistake by renaming d_can1 to dcan1
Changes from v1:
- Separated from "Add DT for AM33XX devices" patch series
- Incorporated Stephen Warren's review comments on v1
* Removed status and interrupt-parent description from
c_can.txt file because these are device specific
parameters.
.../devicetree/bindings/net/can/c_can.txt | 24 +++++++++++++++-----
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/can/c_can.txt b/Documentation/devicetree/bindings/net/can/c_can.txt
index a43f083..8f1ae81 100644
--- a/Documentation/devicetree/bindings/net/can/c_can.txt
+++ b/Documentation/devicetree/bindings/net/can/c_can.txt
@@ -10,7 +10,6 @@ Required properties:
number
Optional properties:
-- interrupt-parent : The parent interrupt controller
- ti,hwmods : Must be "d_can<n>" or "c_can<n>", n being the
instance number
@@ -20,18 +19,31 @@ Future plan is to migrate hwmod data base contents into device tree
blob so that, all the required data will be used from device tree dts
file.
-Examples:
+Example:
- d_can@481D0000 {
+Step1: SoC common .dtsi file
+
+ dcan1: d_can@481d0000 {
compatible = "bosch,d_can";
- reg = <0x481D0000 0x1000>;
- interrupts = <55 0x4>;
+ reg = <0x481d0000 0x2000>;
+ interrupts = <55>;
interrupt-parent = <&intc>;
+ status = "disabled";
};
(or)
- d_can@481D0000 {
+ dcan1: d_can@481d0000 {
compatible = "bosch,d_can";
ti,hwmods = "d_can1";
+ reg = <0x481d0000 0x2000>;
+ interrupts = <55>;
+ interrupt-parent = <&intc>;
+ status = "disabled";
+ };
+
+Step 2: board specific .dts file
+
+ &dcan1 {
+ status = "okay";
};
--
1.7.9.5
next reply other threads:[~2012-09-06 10:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-06 10:02 AnilKumar Ch [this message]
2012-09-06 11:23 ` [PATCH v3] of: Modify c_can binding documentation Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346925725-19873-1-git-send-email-anilkumar@ti.com \
--to=anilkumar@ti.com \
--cc=anantgole@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=nsekhar@ti.com \
--cc=swarren@wwwdotorg.org \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).