From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Archit Taneja <a0393947@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 15/17] OMAPDSS: remove extra_info completion code
Date: Thu, 06 Sep 2012 16:42:06 +0300 [thread overview]
Message-ID: <1346938926.2737.71.camel@deskari> (raw)
In-Reply-To: <5048A6AA.50009@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1798 bytes --]
On Thu, 2012-09-06 at 19:05 +0530, Archit Taneja wrote:
> On Thursday 06 September 2012 06:34 PM, Tomi Valkeinen wrote:
> > On Wed, 2012-09-05 at 19:01 +0530, Archit Taneja wrote:
> >> On Wednesday 05 September 2012 01:55 PM, Tomi Valkeinen wrote:
> >>> Now that fifo merge has been removed, nobody uses the extra_info related
> >>> completion code, which can be removed.
> >>
> >> I think this might come into use when we fix the usage of channel out
> >> field. That is, since channel out is an immediate write field, when we
> >> set a new manager for an overlay, we may need to wait till the overlay
> >> disable kicks in, only then we should change channel out.
> >>
> >> For this, we would need some wait for extra_info, right?
> >
> > Hmm, yes, I think you are right. Previously the ovl_disable waited until
> > the overlay is not used anymore, but now it doesn't.
> >
> > So I think I need to add wait_pending_extra_info_updates() call to the
> > beginning of dss_ovl_set_manager(). Or, should it be in unset_manager...
> > I think unset is better, then a "free" overlay always disabled also in
> > the HW level.
>
> Yes, I also think it should be in unset_manager. One option could be to
> leave the wait_pending_extra_info_updates() in ovl_disable itself, as it
> was before. But that would force us to use mutexes there, and we'd
> rather have overlay enabling and disabling as a non blocking thing.
Actually, we do have mutexes there. You are thinking about the prototype
API I have. (I also thought we didn't have mutex there =).
So, in fact, we can have the wait at ovl_disable like it was before. The
prototype API, which cannot block, will not have the wait, but there the
caller (i.e. omapdrm) will have to manage the proper wait.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-09-06 13:42 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 8:25 [PATCH 00/17] Misc OMAP DSS patches part 2 Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 01/17] OMAPDSS: Taal: use devm_* functions Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 02/17] OMAPFB1: remove unnecessary includes Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 03/17] OMAPFB1: remove a non-used table Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 04/17] OMAPDSS: remove unnecessary includes Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 05/17] OMAPFB: clear framebuffers with CPU Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 06/17] OMAPDSS: VRAM: Remove clearing with sDMA Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 07/17] OMAPDSS: Taal: Reogranize for device tree Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 08/17] OMAPDSS: TFP410: use devm_gpio_request_one Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 09/17] OMAPDSS: split overlay sysfs code Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 10/17] OMAPDSS: split manager " Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 11/17] OMAPDSS: clean up dss_mgr_set_lcd_config Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 12/17] OMAPDSS: clean up dss_mgr_set_timings Tomi Valkeinen
2012-09-05 9:15 ` Archit Taneja
2012-09-05 10:41 ` Tomi Valkeinen
2012-09-05 11:34 ` Archit Taneja
2012-09-05 11:41 ` Tomi Valkeinen
2012-09-05 11:48 ` Archit Taneja
2012-09-07 10:11 ` Tomi Valkeinen
2012-09-07 11:36 ` Archit Taneja
2012-09-05 8:25 ` [PATCH 13/17] Revert "OMAPDSS: APPLY: add fifo-merge support" Tomi Valkeinen
2012-09-05 13:43 ` Archit Taneja
2012-09-06 12:55 ` Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 14/17] Revert "OMAPDSS: APPLY: add fifo merge support funcs" Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 15/17] OMAPDSS: remove extra_info completion code Tomi Valkeinen
2012-09-05 13:31 ` Archit Taneja
2012-09-06 13:04 ` Tomi Valkeinen
2012-09-06 13:35 ` Archit Taneja
2012-09-06 13:42 ` Tomi Valkeinen [this message]
2012-09-06 14:01 ` Archit Taneja
2012-09-06 14:29 ` Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 16/17] OMAPDSS: Improve fifo management code Tomi Valkeinen
2012-09-05 8:25 ` [PATCH 17/17] OMAPDSS: Use WB fifo for GFX overlay Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346938926.2737.71.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=a0393947@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox