Re: [PATCH 15/17] OMAPDSS: remove extra_info completion code

Tomi Valkeinen
2012-09-06T13:04:47Z

[-- Attachment #1: Type: text/plain, Size: 974 bytes --]

On Wed, 2012-09-05 at 19:01 +0530, Archit Taneja wrote:
> On Wednesday 05 September 2012 01:55 PM, Tomi Valkeinen wrote:
> > Now that fifo merge has been removed, nobody uses the extra_info related
> > completion code, which can be removed.
>
> I think this might come into use when we fix the usage of channel out
> field. That is, since channel out is an immediate write field, when we
> set a new manager for an overlay, we may need to wait till the overlay
> disable kicks in, only then we should change channel out.
>
> For this, we would need some wait for extra_info, right?

Hmm, yes, I think you are right. Previously the ovl_disable waited until
the overlay is not used anymore, but now it doesn't.

So I think I need to add wait_pending_extra_info_updates() call to the
beginning of dss_ovl_set_manager(). Or, should it be in unset_manager...
I think unset is better, then a "free" overlay always disabled also in
the HW level.

Tomi

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]