From: Tero Kristo <t-kristo@ti.com>
To: Rajendra Nayak <rnayak@ti.com>
Cc: linux-omap@vger.kernel.org, paul@pwsan.com, khilman@ti.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv5 00/10] ARM: OMAP: PM usecounting changes
Date: Tue, 25 Sep 2012 17:17:56 +0300 [thread overview]
Message-ID: <1348582676.10702.302.camel@sokoban> (raw)
In-Reply-To: <5061A22B.1030603@ti.com>
On Tue, 2012-09-25 at 17:53 +0530, Rajendra Nayak wrote:
> On Tuesday 25 September 2012 05:23 PM, Tero Kristo wrote:
> > On Tue, 2012-09-25 at 15:56 +0530, Rajendra Nayak wrote:
> >> Hi Tero,
> >>
> >> On Tuesday 25 September 2012 03:02 PM, Tero Kristo wrote:
> >>> Hi,
> >>>
> >>> Changes compared to previous version:
> >>
> >> Did you get a chance to look at the issue I reported about autodeps?
> >> http://www.mail-archive.com/linux-omap@vger.kernel.org/msg72876.html
> >
> > Not really, I didn't think that bug report was meant for me, I kind of
> > thought it only happened with your set. But now looking at your email in
> > detail, I guess you are saying there is a bug in this code (the one that
> > touches iclk stuff), which causes the USB / DSS domains to follow
> > MPU/CORE, is that right?
>
> Yes, basically the autodeps remain set, even while the module is not in
> use at all, which causes them to come in and out of sleep along with MPU.
Actually I think I accidentally fixed this problem with the latest rev,
due to the fact that I am using generic clkdm_clk_enable / disable calls
from iclk now.
I also just tested this (while fixing the complaint from Russell), and
it looks like both USB and DSS pwrdms are remaining nicely idle on
OMAP3.
-Tero
>
> >
> > -Tero
> >
> >>
> >> regards,
> >> Rajendra
> >>
> >>>
> >>> - Fixed OMAP4 support (patches 7-10)
> >>> - Dropped debugging support from this set for now
> >>> - Rebased on top of 3.6-rc5 + func-pwrst + omap4-ret code
> >>> (omap4 support easier to test with these)
> >>> - Patch #1:
> >>> * dropped clkdm_usecount_inc / clkdm_usecount_dec APIs
> >>> * clkdm_clk_enable / disable are used now instead
> >>> * some code ordering changed for the new setup to work properly
> >>> * changed BUG_ON calls to WARN_ON
> >>> - Patch #2:
> >>> * added spinlock for protecting voltdm callbacks
> >>> * pwrdm lock extended to protect pwrdm callbacks
> >>> - Patch #3:
> >>> * dropped generic API call for the cpu pwrdm idle / wakeup
> >>> * instead use pwrdm_clkdm_enable / disable calls directly from PM code
> >>> * omap4 support fixed to work properly with SMP, added omap4 specific
> >>> CPU pwrdm idle / wakeup calls for this purpose
> >>> - Patch #4:
> >>> * no changes
> >>> * added 'Reviewed-by' tag for Rajendra
> >>> - Patch #5:
> >>> * no changes, just rebase
> >>> - Patch #6:
> >>> * no changes
> >>>
> >>> Tested with OMAP3 beagle, omap4460 GP panda + omap4430 EMU blaze boards.
> >>>
> >>> I will be posting new versions for the voltdm fixes + auto retention +
> >>> panda board tps6236x support code later on today, which are based on top
> >>> of this set.
> >>>
> >>> Branch also available here:
> >>>
> >>> git://gitorious.org/~kristo/omap-pm/omap-pm-work.git
> >>> branch: mainline-3.6-rc5-pwrdm-changes-v5
> >>>
> >>> -Tero
> >>>
> >>>
> >>> --
> >>> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> >>> the body of a message to majordomo@vger.kernel.org
> >>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> >>>
> >>
> >
> >
>
next prev parent reply other threads:[~2012-09-25 14:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-25 9:32 [PATCHv5 00/10] ARM: OMAP: PM usecounting changes Tero Kristo
2012-09-25 9:32 ` [PATCHv5 01/10] ARM: OMAP3+: voltage/pwrdm/clkdm/clock add recursive usecount tracking Tero Kristo
2012-09-25 9:32 ` [PATCHv5 02/10] ARM: OMAP3+: voltage: add support for voltagedomain usecounts Tero Kristo
2012-09-25 9:41 ` Russell King - ARM Linux
2012-09-25 12:02 ` Tero Kristo
2012-09-25 9:32 ` [PATCHv5 03/10] ARM: OMAP3: add manual control for mpu / core pwrdm usecounting Tero Kristo
2012-09-25 9:32 ` [PATCHv5 04/10] ARM: OMAP3: set autoidle flag for sdrc_ick Tero Kristo
2012-09-25 9:32 ` [PATCHv5 05/10] ARM: OMAP: clockdomain: add support for preventing autodep delete Tero Kristo
2012-09-25 9:32 ` [PATCHv5 06/10] ARM: OMAP3: do not delete per_clkdm autodeps during idle Tero Kristo
2012-09-25 9:32 ` [PATCHv5 07/10] ARM: OMAP4: clock data: set autoidle flag for dss_fck Tero Kristo
2012-09-25 9:32 ` [PATCHv5 08/10] ARM: OMAP4: hwmod: add support for hwmod autoidle flag Tero Kristo
2012-09-25 9:32 ` [PATCHv5 09/10] ARM: OMAP4: hwmod data: set mpu hwmod modulemode to hwauto Tero Kristo
2012-09-25 9:32 ` [PATCHv5 10/10] ARM: OMAP4: clock data: flag hw controlled clocks as autoidle Tero Kristo
2012-09-25 10:26 ` [PATCHv5 00/10] ARM: OMAP: PM usecounting changes Rajendra Nayak
2012-09-25 11:53 ` Tero Kristo
2012-09-25 12:23 ` Rajendra Nayak
2012-09-25 14:17 ` Tero Kristo [this message]
2012-09-26 4:15 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1348582676.10702.302.camel@sokoban \
--to=t-kristo@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox