Re: Converting vrfb.c

[Tomi Valkeinen <tomi.valkeinen@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 2172 bytes --]

On Wed, 2012-10-03 at 11:41 -0700, Tony Lindgren wrote:
> Hi,
> 
> * Tony Lindgren <tony@atomide.com> [120928 08:02]:
> > * Tomi Valkeinen <tomi.valkeinen@ti.com> [120928 05:05]:
> > > Hi,
> > > 
> > > I'm a bit at loss how to deal with drivers/video/omap2/vrfb.c.
> > > 
> > > VRFB is part of the SDRAM controller on OMAP2 and OMAP3. vrfb.c uses the
> > > following functions from sdrc.h:
> > > 
> > > omap2_sms_write_rot_control();
> > > omap2_sms_write_rot_size();
> > > omap2_sms_write_rot_physical_ba();
> > > 
> > > There are no other dependencies to the sdrc.c.
> > > 
> > > Those functions are quite simple:
> > > 
> > > void omap2_sms_write_rot_control(u32 val, unsigned ctx)
> > > {
> > > 	sms_write_reg(val, SMS_ROT_CONTROL(ctx));
> > > }
> > > 
> > > void omap2_sms_write_rot_size(u32 val, unsigned ctx)
> > > {
> > > 	sms_write_reg(val, SMS_ROT_SIZE(ctx));
> > > }
> > > 
> > > void omap2_sms_write_rot_physical_ba(u32 val, unsigned ctx)
> > > {
> > > 	sms_write_reg(val, SMS_ROT_PHYSICAL_BA(ctx));
> > > }
> > > 
> > > vrfb.c is in turn used by omapfb and omap v4l2 driver.
> > > 
> > > 
> > > So... Should I just remove the sdrc.h dependency and make vrfb.c ioremap
> > > those SMS registers itself? Those three registers are VRFB specific, so
> > > they are not used by anyone else. In that case I'd need to pass the SMS
> > > base address to vrfb.c somehow.
> > > 
> > > Or should I have some kind of platform data passed to vrfb.c, which
> > > contains func pointers to the above three functions?
> > > 
> > > Or should vrfb.c be moved into mach-omap2/? But then how would omapfb
> > > call it? Passing vrfb functions as pointers in omapfb platform data?
> > 
> > Maybe just export those functions in sdrc.c for now? Eventually
> > that should be just a regular device driver too..
> 
> Actually, if you're only using it to save and restore the hw
> context, why don't you let mach-omap2/sdrc.c do it based on runtime
> PM calls? It already has omap2_sms_save/restore_context.

No, the functions are used to configure the rotation parameters whenever
the user asks for a new rotation.

 Tomi


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]