[PATCH] staging: drm/omap: fix missing include on omap_crtc

[PATCH] staging: drm/omap: fix missing include on omap_crtc

[Enric Balletbo i Serra]

From: Enric Balletbo i Serra <eballetbo@iseebcn.com>

This fixes following error:

| ...
| CC [M]  drivers/staging/omapdrm/omap_crtc.o
| .../omapdrm/omap_crtc.c:22:22: fatal error: drm_mode.h: No such file or directory
| ...

Signed-off-by: Enric Balletbo i Serra <eballetbo@iseebcn.com>
---
 drivers/staging/omapdrm/omap_crtc.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/omapdrm/omap_crtc.c b/drivers/staging/omapdrm/omap_crtc.c
index 732f2ad..1d54fe9 100644
--- a/drivers/staging/omapdrm/omap_crtc.c
+++ b/drivers/staging/omapdrm/omap_crtc.c
@@ -17,9 +17,9 @@
  * this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include "omap_drv.h"
+#include <drm/drm_mode.h>
 
-#include "drm_mode.h"
+#include "omap_drv.h"
 #include "drm_crtc.h"
 #include "drm_crtc_helper.h"
 
-- 
1.7.5.4

Re: [PATCH] staging: drm/omap: fix missing include on omap_crtc

[Rob Clark]

On 11/28/2012 06:55 AM, Enric Balletbo i Serra wrote:
> From: Enric Balletbo i Serra <eballetbo@iseebcn.com>
>
> This fixes following error:
>
> | ...
> | CC [M]  drivers/staging/omapdrm/omap_crtc.o
> | .../omapdrm/omap_crtc.c:22:22: fatal error: drm_mode.h: No such file or directory
> | ...

fwiw, I have this patch in my local tree that is fixing the same issue:

https://patchwork.kernel.org/patch/1588461/


and I think I've seen at least one other patch for the same thing..   it 
would be nice to at least get one version of this fix in 3.7..

BR,
-R

>
> Signed-off-by: Enric Balletbo i Serra <eballetbo@iseebcn.com>
> ---
>   drivers/staging/omapdrm/omap_crtc.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/omapdrm/omap_crtc.c b/drivers/staging/omapdrm/omap_crtc.c
> index 732f2ad..1d54fe9 100644
> --- a/drivers/staging/omapdrm/omap_crtc.c
> +++ b/drivers/staging/omapdrm/omap_crtc.c
> @@ -17,9 +17,9 @@
>    * this program.  If not, see <http://www.gnu.org/licenses/>.
>    */
>   
> -#include "omap_drv.h"
> +#include <drm/drm_mode.h>
>   
> -#include "drm_mode.h"
> +#include "omap_drv.h"
>   #include "drm_crtc.h"
>   #include "drm_crtc_helper.h"
>   

Re: [PATCH] staging: drm/omap: fix missing include on omap_crtc

[Enric Balletbo Serra]

Hi Rob,

2012/11/29 Rob Clark <rob@ti.com>:
> On 11/28/2012 06:55 AM, Enric Balletbo i Serra wrote:
>>
>> From: Enric Balletbo i Serra <eballetbo@iseebcn.com>
>>
>> This fixes following error:
>>
>> | ...
>> | CC [M]  drivers/staging/omapdrm/omap_crtc.o
>> | .../omapdrm/omap_crtc.c:22:22: fatal error: drm_mode.h: No such file or
>> directory
>> | ...
>
>
> fwiw, I have this patch in my local tree that is fixing the same issue:
>
> https://patchwork.kernel.org/patch/1588461/
>

Thanks, I didn't see this patch in linux-omap ML and others ML that
I'm subscribed. Please skip this patch.

>
> and I think I've seen at least one other patch for the same thing..   it
> would be nice to at least get one version of this fix in 3.7..
>

Completely agree.

Best regards,
   Enric

> BR,
> -R
>
>
>>
>> Signed-off-by: Enric Balletbo i Serra <eballetbo@iseebcn.com>
>> ---
>>   drivers/staging/omapdrm/omap_crtc.c |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/staging/omapdrm/omap_crtc.c
>> b/drivers/staging/omapdrm/omap_crtc.c
>> index 732f2ad..1d54fe9 100644
>> --- a/drivers/staging/omapdrm/omap_crtc.c
>> +++ b/drivers/staging/omapdrm/omap_crtc.c
>> @@ -17,9 +17,9 @@
>>    * this program.  If not, see <http://www.gnu.org/licenses/>.
>>    */
>>   -#include "omap_drv.h"
>> +#include <drm/drm_mode.h>
>>   -#include "drm_mode.h"
>> +#include "omap_drv.h"
>>   #include "drm_crtc.h"
>>   #include "drm_crtc_helper.h"
>>
>
>