linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: balbi@ti.com
Cc: keshava_mgowda@ti.com, rogerq@ti.com, linux-usb@vger.kernel.org,
	linux-omap@vger.kernel.org
Subject: [PATCH v2 02/22] mfd: omap-usb-tll: Fix channel count detection
Date: Wed, 28 Nov 2012 16:48:50 +0200	[thread overview]
Message-ID: <1354114150-11941-3-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1354114150-11941-1-git-send-email-rogerq@ti.com>

Fix channel count detecion for REV2. Also, don't give up
if we don't recognize the IP Revision. We assume the default
number of channels (i.e. 3) for unrecognized IPs.

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 drivers/mfd/omap-usb-tll.c |   20 +++++++++++---------
 1 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/drivers/mfd/omap-usb-tll.c b/drivers/mfd/omap-usb-tll.c
index d1750a4..c083001 100644
--- a/drivers/mfd/omap-usb-tll.c
+++ b/drivers/mfd/omap-usb-tll.c
@@ -98,6 +98,7 @@
 struct usbtll_omap {
 	struct clk				*usbtll_p1_fck;
 	struct clk				*usbtll_p2_fck;
+	int					nch;	/* num. of channels */
 	struct usbtll_omap_platform_data	*pdata;
 	/* secure the register updates */
 	spinlock_t				lock;
@@ -210,7 +211,7 @@ static int __devinit usbtll_omap_probe(struct platform_device *pdev)
 	unsigned				reg;
 	unsigned long				flags;
 	int					ret = 0;
-	int					i, ver, count;
+	int					i, ver;
 
 	dev_dbg(dev, "starting TI HSUSB TLL Controller\n");
 
@@ -262,16 +263,18 @@ static int __devinit usbtll_omap_probe(struct platform_device *pdev)
 	ver =  usbtll_read(base, OMAP_USBTLL_REVISION);
 	switch (ver) {
 	case OMAP_USBTLL_REV1:
-	case OMAP_USBTLL_REV2:
-		count = OMAP_TLL_CHANNEL_COUNT;
+		tll->nch = OMAP_TLL_CHANNEL_COUNT;
 		break;
+	case OMAP_USBTLL_REV2:
 	case OMAP_USBTLL_REV3:
-		count = OMAP_REV2_TLL_CHANNEL_COUNT;
+		tll->nch = OMAP_REV2_TLL_CHANNEL_COUNT;
 		break;
 	default:
-		dev_err(dev, "TLL version failed\n");
-		ret = -ENODEV;
-		goto err_ioremap;
+		tll->nch = OMAP_TLL_CHANNEL_COUNT;
+		dev_dbg(dev,
+		 "USB TLL Rev : 0x%x not recognized, assuming %d channels\n",
+			ver, tll->nch);
+		break;
 	}
 
 	if (is_ehci_tll_mode(pdata->port_mode[0]) ||
@@ -291,7 +294,7 @@ static int __devinit usbtll_omap_probe(struct platform_device *pdev)
 		usbtll_write(base, OMAP_TLL_SHARED_CONF, reg);
 
 		/* Enable channels now */
-		for (i = 0; i < count; i++) {
+		for (i = 0; i < tll->nch; i++) {
 			reg = usbtll_read(base,	OMAP_TLL_CHANNEL_CONF(i));
 
 			if (is_ohci_port(pdata->port_mode[i])) {
@@ -319,7 +322,6 @@ static int __devinit usbtll_omap_probe(struct platform_device *pdev)
 		}
 	}
 
-err_ioremap:
 	spin_unlock_irqrestore(&tll->lock, flags);
 	iounmap(base);
 	pm_runtime_put_sync(dev);
-- 
1.7.4.1


  parent reply	other threads:[~2012-11-28 14:49 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-28 14:48 [PATCH v2 00/22] OMAP USB Host cleanup Roger Quadros
2012-11-28 14:48 ` [PATCH v2 01/22] mfd: omap-usb-tll: Avoid creating copy of platform data Roger Quadros
2012-11-28 14:48 ` Roger Quadros [this message]
2012-11-28 14:48 ` [PATCH v2 03/22] mfd: omap-usb-tll: Use devm_kzalloc/ioremap and clean up error path Roger Quadros
2012-11-28 14:48 ` [PATCH v2 04/22] mfd: omap-usb-tll: Clean up clock handling Roger Quadros
2012-11-28 14:48 ` [PATCH v2 07/22] mfd: omap-usb-tll: Fix error message Roger Quadros
     [not found] ` <1354114150-11941-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2012-11-28 14:48   ` [PATCH v2 05/22] mfd: omap-usb-tll: introduce and use mode_needs_tll() Roger Quadros
2012-11-28 14:48   ` [PATCH v2 06/22] mfd: omap-usb-tll: Check for missing platform data in probe Roger Quadros
2012-11-28 14:48   ` [PATCH v2 08/22] mfd: omap-usb-tll: serialize access to TLL device Roger Quadros
2012-11-28 14:48   ` [PATCH v2 09/22] mfd: omap-usb-tll: Add OMAP5 revision and HSIC support Roger Quadros
2012-11-28 14:48   ` [PATCH v2 10/22] mfd: omap_usb_host: Avoid creating copy of platform_data Roger Quadros
2012-11-28 14:48   ` [PATCH v2 11/22] mfd: omap-usb-host: Use devm_kzalloc() and devm_request_and_ioremap() Roger Quadros
2012-11-28 14:49   ` [PATCH v2 15/22] ARM: OMAP2+: clock data: Merge utmi_px_gfclk into usb_host_hs_utmi_px_clk Roger Quadros
2012-11-28 14:49   ` [PATCH v2 18/22] mfd: omap-usb-host: get rid of cpu_is_omap..() macros Roger Quadros
     [not found]     ` <1354114150-11941-19-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2012-11-28 16:36       ` Tony Lindgren
2012-11-28 16:49         ` Roger Quadros
2012-11-28 14:49 ` [PATCH v2 12/22] mfd: omap-usb-host: know about number of ports from revision register Roger Quadros
2012-11-28 14:49 ` [PATCH v2 13/22] mfd: omap-usb-host: override number of ports from platform data Roger Quadros
2012-11-28 16:33   ` Tony Lindgren
     [not found]   ` <1354114150-11941-14-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2012-12-02 17:14     ` Sergei Shtylyov
     [not found]       ` <50BB8C73.7060008-Igf4POYTYCDQT0dZR+AlfA@public.gmane.org>
2012-12-03 15:58         ` Roger Quadros
2012-12-04 12:32           ` Sergei Shtylyov
2012-11-28 14:49 ` [PATCH v2 14/22] mfd: omap-usb-host: cleanup clock management code Roger Quadros
2012-11-28 14:49 ` [PATCH v2 16/22] mfd: omap-usb-host: Manage HSIC clocks for HSIC mode Roger Quadros
2012-11-28 14:49 ` [PATCH v2 17/22] mfd: omap-usb-host: Get rid of unnecessary spinlock Roger Quadros
2012-11-28 14:49 ` [PATCH v2 19/22] mfd: omap-usb-host: clean up omap_usbhs_init() Roger Quadros
2012-11-28 14:49 ` [PATCH v2 20/22] USB: ehci-omap: Don't free gpios that we didn't request Roger Quadros
2012-11-28 14:49 ` [PATCH v2 21/22] ARM: OMAP2+: clock data: get rid of unused USB host clock aliases Roger Quadros
     [not found]   ` <1354114150-11941-22-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2012-11-29 11:24     ` Paul Walmsley
2012-11-28 14:49 ` [PATCH v2 22/22] mfd: omap-usb-host: Don't spam console on clk_set_parent failure Roger Quadros
2012-12-02 17:10   ` Sergei Shtylyov
2012-12-03  7:48     ` Bjørn Mork
     [not found]       ` <87ehj7y3s2.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
2012-12-03 15:50         ` Roger Quadros
2012-12-03 15:48     ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354114150-11941-3-git-send-email-rogerq@ti.com \
    --to=rogerq@ti.com \
    --cc=balbi@ti.com \
    --cc=keshava_mgowda@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).