From: Grazvydas Ignotas <notasas@gmail.com>
To: linux-usb@vger.kernel.org
Cc: linux-omap@vger.kernel.org, Felipe Balbi <balbi@ti.com>,
NeilBrown <neilb@suse.de>, Grazvydas Ignotas <notasas@gmail.com>
Subject: [PATCH 6/7] usb: musb: omap2430: turn off vbus on cable disconnect
Date: Sun, 10 Mar 2013 03:08:00 +0200 [thread overview]
Message-ID: <1362877681-8102-7-git-send-email-notasas@gmail.com> (raw)
In-Reply-To: <1362877681-8102-1-git-send-email-notasas@gmail.com>
On USB_EVENT_ID event the musb glue enables VBUS by calling
omap2430_musb_set_vbus(musb, 1) that sets the session bit, but on
USB_EVENT_NONE reverse action is never made, and that breaks PM.
Disable VBUS unconditionally on USB_EVENT_NONE to be sure musb
session is ended on cable unplug so that PM works.
Signed-off-by: Grazvydas Ignotas <notasas@gmail.com>
---
drivers/usb/musb/omap2430.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c
index 2a39c11..d430677 100644
--- a/drivers/usb/musb/omap2430.c
+++ b/drivers/usb/musb/omap2430.c
@@ -296,6 +296,7 @@ static void omap_musb_set_mailbox(struct omap2430_glue *glue)
pm_runtime_put_autosuspend(dev);
}
+ omap2430_musb_set_vbus(musb, 0);
if (data->interface_type == MUSB_INTERFACE_UTMI) {
if (musb->xceiv->otg->set_vbus)
otg_set_vbus(musb->xceiv->otg, 0);
--
1.7.9.5
next prev parent reply other threads:[~2013-03-10 1:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-10 1:07 [PATCH 0/7] usb: otg: twl4030-usb fixes Grazvydas Ignotas
2013-03-10 1:07 ` [PATCH 1/7] usb: otg: twl4030-usb: don't enable PHY during init Grazvydas Ignotas
2013-03-10 1:07 ` [PATCH 2/7] usb: otg: twl4030-usb: ignore duplicate events Grazvydas Ignotas
2013-03-12 13:32 ` kishon
2013-03-12 14:55 ` Grazvydas Ignotas
2013-03-10 1:07 ` [PATCH 3/7] usb: otg: twl4030-usb: don't switch the phy on/off needlessly Grazvydas Ignotas
2013-03-10 1:07 ` [PATCH 4/7] usb: otg: twl4030-usb: poll for ID disconnect Grazvydas Ignotas
[not found] ` <1362877681-8102-5-git-send-email-notasas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-03-10 11:03 ` Michael Trimarchi
2013-03-10 14:49 ` Grazvydas Ignotas
2013-03-10 1:07 ` [PATCH 5/7] usb: otg: twl4030-usb: check if vbus is driven by twl itself Grazvydas Ignotas
2013-03-10 1:08 ` Grazvydas Ignotas [this message]
2013-03-12 13:37 ` [PATCH 6/7] usb: musb: omap2430: turn off vbus on cable disconnect kishon
[not found] ` <513F2F7C.3040803-l0cyMroinI0@public.gmane.org>
2013-03-12 15:03 ` Grazvydas Ignotas
[not found] ` <1362877681-8102-1-git-send-email-notasas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-03-10 1:08 ` [PATCH 7/7] usb: musb: gadget: use platform callback to enable vbus Grazvydas Ignotas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1362877681-8102-7-git-send-email-notasas@gmail.com \
--to=notasas@gmail.com \
--cc=balbi@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).