Re: [PATCH] OMAPDSS: DPI: add dependency to DSI

[Christoph Fritz <chf.fritz@googlemail.com>]

On Thu, 2013-04-18 at 12:21 +0300, Tomi Valkeinen wrote:
> On 2013-04-18 12:09, Tomi Valkeinen wrote:
> > On 2013-04-18 11:37, Christoph Fritz wrote:
> 
> >> With linux-next this patch breaks compiling here because DPI now depends
> >> on DSI - but my omap3 board here doesn't use DSI at all:
> >>
> >> drivers/video/omap2/dss/dpi.c: In function ‘dpi_calc_pll_cb’:
> >> drivers/video/omap2/dss/dpi.c:181: error: implicit declaration of function ‘dsi_hsdiv_calc’
> >> drivers/video/omap2/dss/dpi.c: In function ‘dpi_dsi_clk_calc’:
> >> drivers/video/omap2/dss/dpi.c:201: error: implicit declaration of function ‘dsi_get_pll_clkin’
> >> drivers/video/omap2/dss/dpi.c:212: error: implicit declaration of function ‘dsi_pll_calc’
> >>
> >> Enabling OMAP2_DSS_DSI fixes this. This is my proposed patch. You may be want to merge it?
> > 
> > Thanks for reporting this. We shouldn't make DPI depend on DSI. We
> > should make dummy functions for the above when DSI is not enabled so
> > that DPI compiles. I'll make a fix.
> 
> Patch below. Can you try it out? It works for me on Panda.

Thanks, it compiles here fine too.

and while booting I'm now getting as with 3.9-rc:
[    0.409729] OMAP DSS rev 2.0
[    0.410980] omapdss DPI error: can't get VDDS_DSI regulator
[    0.410980] omapdss DPI error: device ips-056t init failed: -517

But here with linux-next (in contrast to 3.9-rc) removing all regulator
dependencies from drivers/video/omap2/dss/dpi.c does not make the trick.
The display stays dark :-( ...

 Thanks
  -- Christoph

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html