* [PATCH] arm: omap: board-overo: reset GPIO for SMSC911x
@ 2013-05-21 13:47 Florian Vaussard
2013-06-18 10:09 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Florian Vaussard @ 2013-05-21 13:47 UTC (permalink / raw)
To: Tony Lindgren
Cc: Steve Sakoman, Mike Rapoport, linux-omap, linux-arm-kernel,
Florian Vaussard
The reset GPIO should be set for the SMSC911x, otherwise the controller
will not work and probing will fail. In the case of the tobi-duo
expansion board, the second controller shares the same GPIO, thus no
more changes are required (not tested).
Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
---
arch/arm/mach-omap2/board-overo.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c
index 4ca6b68..5748b5d 100644
--- a/arch/arm/mach-omap2/board-overo.c
+++ b/arch/arm/mach-omap2/board-overo.c
@@ -68,6 +68,7 @@
#define OVERO_SMSC911X_CS 5
#define OVERO_SMSC911X_GPIO 176
+#define OVERO_SMSC911X_NRESET 64
#define OVERO_SMSC911X2_CS 4
#define OVERO_SMSC911X2_GPIO 65
@@ -122,7 +123,7 @@ static struct omap_smsc911x_platform_data smsc911x_cfg = {
.id = 0,
.cs = OVERO_SMSC911X_CS,
.gpio_irq = OVERO_SMSC911X_GPIO,
- .gpio_reset = -EINVAL,
+ .gpio_reset = OVERO_SMSC911X_NRESET,
.flags = SMSC911X_USE_32BIT,
};
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] arm: omap: board-overo: reset GPIO for SMSC911x
2013-05-21 13:47 [PATCH] arm: omap: board-overo: reset GPIO for SMSC911x Florian Vaussard
@ 2013-06-18 10:09 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2013-06-18 10:09 UTC (permalink / raw)
To: Florian Vaussard
Cc: Steve Sakoman, Mike Rapoport, linux-omap, linux-arm-kernel
* Florian Vaussard <florian.vaussard@epfl.ch> [130521 07:01]:
> The reset GPIO should be set for the SMSC911x, otherwise the controller
> will not work and probing will fail. In the case of the tobi-duo
> expansion board, the second controller shares the same GPIO, thus no
> more changes are required (not tested).
>
> Signed-off-by: Florian Vaussard <florian.vaussard@epfl.ch>
Thanks applying into omap-for-v3.11/board.
Regards,
Tony
> ---
> arch/arm/mach-omap2/board-overo.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-overo.c b/arch/arm/mach-omap2/board-overo.c
> index 4ca6b68..5748b5d 100644
> --- a/arch/arm/mach-omap2/board-overo.c
> +++ b/arch/arm/mach-omap2/board-overo.c
> @@ -68,6 +68,7 @@
>
> #define OVERO_SMSC911X_CS 5
> #define OVERO_SMSC911X_GPIO 176
> +#define OVERO_SMSC911X_NRESET 64
> #define OVERO_SMSC911X2_CS 4
> #define OVERO_SMSC911X2_GPIO 65
>
> @@ -122,7 +123,7 @@ static struct omap_smsc911x_platform_data smsc911x_cfg = {
> .id = 0,
> .cs = OVERO_SMSC911X_CS,
> .gpio_irq = OVERO_SMSC911X_GPIO,
> - .gpio_reset = -EINVAL,
> + .gpio_reset = OVERO_SMSC911X_NRESET,
> .flags = SMSC911X_USE_32BIT,
> };
>
> --
> 1.7.5.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-06-18 10:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-21 13:47 [PATCH] arm: omap: board-overo: reset GPIO for SMSC911x Florian Vaussard
2013-06-18 10:09 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).