linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [RFC 5/5] DMA: EDMA: Leave linked to Null slot instead of DUMMY slot
@ 2013-07-21  6:58 Joel Fernandes
  0 siblings, 0 replies; only message in thread
From: Joel Fernandes @ 2013-07-21  6:58 UTC (permalink / raw)
  To: Tony Lindgren, Sekhar Nori, Santosh Shilimkar, Sricharan R,
	Rajendra Nayak, Lokesh Vutla, Matt Porter, Grant Likely,
	Rob Herring, Vinod Koul, Dan Williams, Mark Brown, Benoit Cousson,
	Russell King, Arnd Bergmann, Balaji TK, Gururaja Hebbar,
	Chris Ball, Jason Kridner
  Cc: Linux DaVinci Kernel List, Joel Fernandes, Linux MMC List,
	Linux Kernel Mailing List, Linux OMAP List, Linux ARM Kernel List

Dummy slot has been used as a way for missed-events not to be
reported as missing. This has been particularly troublesome for cases
where we might want to temporarily pause all incoming events.

For EDMA DMAC, there is no way to do any such pausing of events as
the occurence of the "next" event is not software controlled.
Using "edma_pause" in IRQ handlers doesn't help as by then the event
in concern from the slave is already missed.

Linking a dummy slot, is seen to absorb these events which we didn't
want to miss. So we don't link to dummy, but instead leave it linked
to NULL set, allow an error condition and detect the channel that
missed it.

Signed-off-by: Joel Fernandes <joelf-l0cyMroinI0@public.gmane.org>
---
 drivers/dma/edma.c |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
index b0b5bcd..e9f1f27 100644
--- a/drivers/dma/edma.c
+++ b/drivers/dma/edma.c
@@ -160,9 +160,6 @@ static void edma_execute(struct edma_chan *echan)
 		/* Link to the previous slot if not the last set */
 		if (i != (total_process - 1))
 			edma_link(echan->slot[i], echan->slot[i+1]);
-		/* Final pset links to the dummy pset */
-		else
-			edma_link(echan->slot[i], echan->ecc->dummy_slot);
 	}
 
 	edesc->total_processed += total_process;
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2013-07-21  6:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-21  6:58 [RFC 5/5] DMA: EDMA: Leave linked to Null slot instead of DUMMY slot Joel Fernandes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).