From: Rajendra Nayak <rnayak@ti.com>
To: tony@atomide.com, linux-omap@vger.kernel.org
Cc: paul@pwsan.com, balbi@ti.com, mpfj-list@newflow.co.uk,
vaibhav.bedia@ti.com, khilman@linaro.org, sourav.poddar@ti.com,
linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org,
linux-serial@vger.kernel.org, grygorii.strashko@ti.com,
Rajendra Nayak <rnayak@ti.com>
Subject: [PATCH 3/4] ARM: OMAP2+: Avoid idling memory controllers with no drivers
Date: Mon, 22 Jul 2013 15:31:16 +0530 [thread overview]
Message-ID: <1374487277-26099-4-git-send-email-rnayak@ti.com> (raw)
In-Reply-To: <1374487277-26099-1-git-send-email-rnayak@ti.com>
Memory controllers in OMAP (like GPMC and EMIF) have the hwmods marked with
HWMOD_INIT_NO_IDLE and are left in enabled state post initial setup.
Even if they have drivers missing, avoid idling them as part of
omap_device_late_idle()
Signed-off-by: Rajendra Nayak <rnayak@ti.com>
---
arch/arm/mach-omap2/omap_device.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/mach-omap2/omap_device.c b/arch/arm/mach-omap2/omap_device.c
index 5cc9287..1c82cde 100644
--- a/arch/arm/mach-omap2/omap_device.c
+++ b/arch/arm/mach-omap2/omap_device.c
@@ -842,6 +842,7 @@ static int __init omap_device_late_idle(struct device *dev, void *data)
{
struct platform_device *pdev = to_platform_device(dev);
struct omap_device *od = to_omap_device(pdev);
+ int i;
if (!od)
return 0;
@@ -850,6 +851,15 @@ static int __init omap_device_late_idle(struct device *dev, void *data)
* If omap_device state is enabled, but has no driver bound,
* idle it.
*/
+
+ /*
+ * Some devices (like memory controllers) are always kept
+ * enabled, and should not be idled even with no drivers.
+ */
+ for (i = 0; i < od->hwmods_cnt; i++)
+ if (od->hwmods[i]->flags & HWMOD_INIT_NO_IDLE)
+ return 0;
+
if (od->_driver_status != BUS_NOTIFY_BOUND_DRIVER) {
if (od->_state == OMAP_DEVICE_STATE_ENABLED) {
dev_warn(dev, "%s: enabled but no driver. Idling\n",
--
1.7.9.5
next prev parent reply other threads:[~2013-07-22 10:02 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 10:01 [PATCH 0/4] OMAP2+: Fix boot hang with earlycon enabled Rajendra Nayak
2013-07-22 10:01 ` [PATCH 1/4] ARM: OMAP2+: hwmod: Fix a crash in _setup_reset() with DEBUG_LL Rajendra Nayak
2013-07-22 10:01 ` [PATCH 2/4] serial: omap: enable PM runtime only when its fully configured Rajendra Nayak
2013-07-29 8:44 ` Paul Walmsley
2013-07-29 8:50 ` Rajendra Nayak
2013-07-30 5:16 ` Rajendra Nayak
2013-07-30 10:20 ` Paul Walmsley
2013-07-22 10:01 ` Rajendra Nayak [this message]
2013-07-22 17:48 ` [PATCH 3/4] ARM: OMAP2+: Avoid idling memory controllers with no drivers Paul Walmsley
2013-07-23 4:59 ` Rajendra Nayak
2013-07-22 10:01 ` [PATCH 4/4] ARM: OMAP2+: Sync hwmod state with the pm_runtime and omap_device state Rajendra Nayak
2013-08-05 15:43 ` Kevin Hilman
2013-07-22 14:52 ` [PATCH 0/4] OMAP2+: Fix boot hang with earlycon enabled Mark Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1374487277-26099-4-git-send-email-rnayak@ti.com \
--to=rnayak@ti.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=grygorii.strashko@ti.com \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mpfj-list@newflow.co.uk \
--cc=paul@pwsan.com \
--cc=sourav.poddar@ti.com \
--cc=tony@atomide.com \
--cc=vaibhav.bedia@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).