From: Joel Fernandes <joelf@ti.com>
To: Tony Lindgren <tony@atomide.com>, Sekhar Nori <nsekhar@ti.com>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Sricharan R <r.sricharan@ti.com>, Rajendra Nayak <rnayak@ti.com>,
Lokesh Vutla <lokeshvutla@ti.com>,
Matt Porter <matt@ohporter.com>,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
Vinod Koul <vinod.koul@intel.com>, Dan Williams <djbw@fb.com>,
Mark Brown <broonie@linaro.org>,
Benoit Cousson <benoit.cousson@linaro.org>,
Russell King <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
Balaji TK <balajitk@ti.com>,
Gururaja Hebbar <gururaja.hebbar@ti.com>,
Chris Ball <cjb@laptop.org>,
Jason Kridner <jkridner@beagleboard.org>
Cc: Linux DaVinci Kernel List
<davinci-linux-open-source@linux.davincidsp.com>,
Joel Fernandes <joelf@ti.com>,
Linux MMC List <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux OMAP List <linux-omap@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>
Subject: [PATCH 5/9] dma: edma: Leave linked to Null slot instead of DUMMY slot
Date: Mon, 29 Jul 2013 08:29:51 -0500 [thread overview]
Message-ID: <1375104595-16018-6-git-send-email-joelf@ti.com> (raw)
In-Reply-To: <1375104595-16018-1-git-send-email-joelf@ti.com>
Dummy slot has been used as a way for missed-events not to be
reported as missing. This has been particularly troublesome for cases
where we might want to temporarily pause all incoming events.
For EDMA DMAC, there is no way to do any such pausing of events as
the occurence of the "next" event is not software controlled.
Using "edma_pause" in IRQ handlers doesn't help as by then the event
in concern from the slave is already missed.
Linking a dummy slot, is seen to absorb these events which we didn't
want to miss. So we don't link to dummy, but instead leave it linked
to NULL set, allow an error condition and detect the channel that
missed it.
Signed-off-by: Joel Fernandes <joelf@ti.com>
---
drivers/dma/edma.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
index aa4989f..1eda5cc 100644
--- a/drivers/dma/edma.c
+++ b/drivers/dma/edma.c
@@ -159,9 +159,6 @@ static void edma_execute(struct edma_chan *echan)
/* Link to the previous slot if not the last set */
if (i != (total_process - 1))
edma_link(echan->slot[i], echan->slot[i+1]);
- /* Final pset links to the dummy pset */
- else
- edma_link(echan->slot[i], echan->ecc->dummy_slot);
}
edesc->total_processed += total_process;
--
1.7.9.5
next prev parent reply other threads:[~2013-07-29 13:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 13:29 [PATCH 0/9] dma: edma: Support scatter-lists of any length Joel Fernandes
[not found] ` <1375104595-16018-1-git-send-email-joelf-l0cyMroinI0@public.gmane.org>
2013-07-29 13:29 ` [PATCH 1/9] dma: edma: Setup parameters to DMA MAX_NR_SG at a time Joel Fernandes
2013-07-29 13:29 ` [PATCH 2/9] dma: edma: Write out and handle MAX_NR_SG at a given time Joel Fernandes
2013-07-29 13:29 ` [PATCH 3/9] ARM: edma: Add function to manually trigger an EDMA channel Joel Fernandes
[not found] ` <1375104595-16018-4-git-send-email-joelf-l0cyMroinI0@public.gmane.org>
2013-07-30 5:18 ` Sekhar Nori
[not found] ` <51F74CAD.3040604-l0cyMroinI0@public.gmane.org>
2013-07-31 4:30 ` Joel Fernandes
[not found] ` <51F892D2.4090805-l0cyMroinI0@public.gmane.org>
2013-07-31 5:23 ` Sekhar Nori
[not found] ` <51F89F5E.2050605-l0cyMroinI0@public.gmane.org>
2013-07-31 5:34 ` Fernandes, Joel
2013-07-29 13:29 ` [PATCH 4/9] dma: edma: Find missed events and issue them Joel Fernandes
[not found] ` <1375104595-16018-5-git-send-email-joelf-l0cyMroinI0@public.gmane.org>
2013-07-30 7:05 ` Sekhar Nori
[not found] ` <51F7659E.3040302-l0cyMroinI0@public.gmane.org>
2013-07-31 4:49 ` Joel Fernandes
[not found] ` <51F89763.1010102-l0cyMroinI0@public.gmane.org>
2013-07-31 9:18 ` Sekhar Nori
[not found] ` <51F8D667.2040406-l0cyMroinI0@public.gmane.org>
2013-08-01 2:27 ` Joel Fernandes
[not found] ` <51F9C793.2000001-l0cyMroinI0@public.gmane.org>
2013-08-01 3:43 ` Joel Fernandes
2013-08-01 4:39 ` Joel Fernandes
2013-08-01 6:13 ` Sekhar Nori
[not found] ` <51F9FC87.3020706-l0cyMroinI0@public.gmane.org>
2013-08-01 20:28 ` Joel Fernandes
[not found] ` <51FAC50A.2020507-l0cyMroinI0@public.gmane.org>
2013-08-01 20:48 ` Joel Fernandes
2013-08-02 13:26 ` Sekhar Nori
[not found] ` <51FBB371.6030901-l0cyMroinI0@public.gmane.org>
2013-08-02 18:15 ` Joel Fernandes
[not found] ` <51FBF749.4010303-l0cyMroinI0@public.gmane.org>
2013-08-02 23:00 ` Joel Fernandes
2013-07-29 13:29 ` Joel Fernandes [this message]
2013-07-29 13:29 ` [PATCH 6/9] dma: edma: Detect null slot errors and handle them correctly Joel Fernandes
2013-07-29 13:29 ` [PATCH 7/9] ARM: edma: Don't clear EMR of channel in edma_stop Joel Fernandes
[not found] ` <1375104595-16018-8-git-send-email-joelf-l0cyMroinI0@public.gmane.org>
2013-07-30 8:29 ` Sekhar Nori
[not found] ` <51F77982.7030601-l0cyMroinI0@public.gmane.org>
2013-07-31 5:05 ` Joel Fernandes
[not found] ` <51F89B0B.4080803-l0cyMroinI0@public.gmane.org>
2013-07-31 9:35 ` Sekhar Nori
[not found] ` <51F8DA5C.9060503-l0cyMroinI0@public.gmane.org>
2013-08-01 1:59 ` Joel Fernandes
2013-07-29 13:29 ` [PATCH 8/9] dma: edma: Link to dummy slot only for last SG list split Joel Fernandes
2013-07-29 13:29 ` [PATCH 9/9] dma: edma: remove limits on number of slots Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375104595-16018-6-git-send-email-joelf@ti.com \
--to=joelf@ti.com \
--cc=arnd@arndb.de \
--cc=balajitk@ti.com \
--cc=benoit.cousson@linaro.org \
--cc=broonie@linaro.org \
--cc=cjb@laptop.org \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=djbw@fb.com \
--cc=grant.likely@secretlab.ca \
--cc=gururaja.hebbar@ti.com \
--cc=jkridner@beagleboard.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lokeshvutla@ti.com \
--cc=matt@ohporter.com \
--cc=nsekhar@ti.com \
--cc=olof@lixom.net \
--cc=r.sricharan@ti.com \
--cc=rnayak@ti.com \
--cc=rob.herring@calxeda.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).