Re: [PATCH 3/4] dts: dra7-evm: add USB support

George Cherian
2013-08-05T09:03:01Z

On 8/5/2013 1:25 PM, Roger Quadros wrote:
> On 08/02/2013 06:04 PM, George Cherian wrote:
>> On 8/1/2013 8:28 PM, Roger Quadros wrote:
>>> Add USB drv_vbus pinctrl information and USB mode
>>> for the USB controller.
>>>
>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>>> ---
>>> arch/arm/boot/dts/dra7-evm.dts | 22 ++++++++++++++++++++++
>>> 1 files changed, 22 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/dra7-evm.dts b/arch/arm/boot/dts/dra7-evm.dts
>>> index cb0703c..acd3c09 100644
>>> --- a/arch/arm/boot/dts/dra7-evm.dts
>>> +++ b/arch/arm/boot/dts/dra7-evm.dts
>>> @@ -18,3 +18,25 @@
>>> reg = <0x80000000 0x60000000>; /* 1536 MB */
>>> };
>>> };
>>> +
>>> +&dra7_pmx_core {
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <
>>> + &usb_pins
>>> + >;
>>> +
>>> + usb_pins: pinmux_usb_pins {
>>> + pinctrl-single,pins = <
>>> + 0x280 0xc0000 /* usb1_drvvbus, SLOW_SLEW | PULLUPEN | MODE0 */
>>> + 0x284 0xc0000 /* usb2_drvvbus, SLOW_SLEW | PULLUPEN | MODE0 */
>>> + >;
>>> + };
>>> +};
>>> +
>>> +&dwc3_1 {
>>> + dr_mode = "otg";
>> otg???
> What's wrong there?
> please see
> Documentation/devicetree/bindings/usb/generic.txt
>
> we want it to operate in dual role mode and hence "otg"

Am sorry for not being clear with my earlier comment.
I meant whether we have otg/ DRD working. Till then shouldnt we put
either peripheral/host?
> cheers,
> -roger

--
-George