* [PATCH] ARM: dts: igep00x0: Add pinmux configuration for MCBSP2.
@ 2013-09-10 15:35 Enric Balletbo i Serra
2013-09-10 15:38 ` Enric Balletbo Serra
0 siblings, 1 reply; 7+ messages in thread
From: Enric Balletbo i Serra @ 2013-09-10 15:35 UTC (permalink / raw)
To: linux-omap, Benoit Cousson, Tony Lindgren,
Javier Martinez Canillas
Cc: Enric Balletbo i Serra
Add pinmux configuration for MCBSP2 connected to the TDM interface. With
this configuration the Headset modules works as expected.
Signed-off-by: Enric Balletbo i Serra <eballetbo@gmail.com>
Acked-by: Javier Martinez Canillas <javier@dowhile0.org>
---
arch/arm/boot/dts/omap3-igep.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi
index bc48b11..2326d11 100644
--- a/arch/arm/boot/dts/omap3-igep.dtsi
+++ b/arch/arm/boot/dts/omap3-igep.dtsi
@@ -48,6 +48,15 @@
>;
};
+ mcbsp2_pins: pinmux_mcbsp2_pins {
+ pinctrl-single,pins = <
+ 0x10c (PIN_INPUT | MUX_MODE0) /* mcbsp2_fsx.mcbsp2_fsx */
+ 0x10e (PIN_INPUT | MUX_MODE0) /* mcbsp2_clkx.mcbsp2_clkx */
+ 0x110 (PIN_INPUT | MUX_MODE0) /* mcbsp2_dr.mcbsp2.dr */
+ 0x112 (PIN_OUTPUT | MUX_MODE0) /* mcbsp2_dx.mcbsp2_dx */
+ >;
+ };
+
mmc1_pins: pinmux_mmc1_pins {
pinctrl-single,pins = <
0x114 (PIN_INPUT_PULLUP | MUX_MODE0) /* sdmmc1_clk.sdmmc1_clk */
@@ -93,6 +102,11 @@
clock-frequency = <400000>;
};
+&mcbsp2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&mcbsp2_pins>;
+};
+
&mmc1 {
pinctrl-names = "default";
pinctrl-0 = <&mmc1_pins>;
--
1.8.1.2
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: dts: igep00x0: Add pinmux configuration for MCBSP2.
2013-09-10 15:35 [PATCH] ARM: dts: igep00x0: Add pinmux configuration for MCBSP2 Enric Balletbo i Serra
@ 2013-09-10 15:38 ` Enric Balletbo Serra
2013-09-18 12:33 ` Benoit Cousson
0 siblings, 1 reply; 7+ messages in thread
From: Enric Balletbo Serra @ 2013-09-10 15:38 UTC (permalink / raw)
To: linux-omap@vger.kernel.org, Benoit Cousson, Tony Lindgren,
Javier Martinez Canillas
Cc: Enric Balletbo i Serra
2013/9/10 Enric Balletbo i Serra <eballetbo@gmail.com>:
> Add pinmux configuration for MCBSP2 connected to the TDM interface. With
> this configuration the Headset modules works as expected.
>
> Signed-off-by: Enric Balletbo i Serra <eballetbo@gmail.com>
> Acked-by: Javier Martinez Canillas <javier@dowhile0.org>
> ---
> arch/arm/boot/dts/omap3-igep.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi
> index bc48b11..2326d11 100644
> --- a/arch/arm/boot/dts/omap3-igep.dtsi
> +++ b/arch/arm/boot/dts/omap3-igep.dtsi
> @@ -48,6 +48,15 @@
> >;
> };
>
> + mcbsp2_pins: pinmux_mcbsp2_pins {
> + pinctrl-single,pins = <
> + 0x10c (PIN_INPUT | MUX_MODE0) /* mcbsp2_fsx.mcbsp2_fsx */
> + 0x10e (PIN_INPUT | MUX_MODE0) /* mcbsp2_clkx.mcbsp2_clkx */
> + 0x110 (PIN_INPUT | MUX_MODE0) /* mcbsp2_dr.mcbsp2.dr */
> + 0x112 (PIN_OUTPUT | MUX_MODE0) /* mcbsp2_dx.mcbsp2_dx */
> + >;
> + };
> +
> mmc1_pins: pinmux_mmc1_pins {
> pinctrl-single,pins = <
> 0x114 (PIN_INPUT_PULLUP | MUX_MODE0) /* sdmmc1_clk.sdmmc1_clk */
> @@ -93,6 +102,11 @@
> clock-frequency = <400000>;
> };
>
> +&mcbsp2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&mcbsp2_pins>;
> +};
> +
> &mmc1 {
> pinctrl-names = "default";
> pinctrl-0 = <&mmc1_pins>;
> --
> 1.8.1.2
>
Hi Benoit,
I sent this patch some time ago to be merged as a fix for 3.11, but
seems was not merged. Would be possible include this patch in these
series ?
Best regards,
Enric
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: dts: igep00x0: Add pinmux configuration for MCBSP2.
2013-09-10 15:38 ` Enric Balletbo Serra
@ 2013-09-18 12:33 ` Benoit Cousson
2013-09-19 6:31 ` Enric Balletbo Serra
0 siblings, 1 reply; 7+ messages in thread
From: Benoit Cousson @ 2013-09-18 12:33 UTC (permalink / raw)
To: Enric Balletbo Serra
Cc: linux-omap@vger.kernel.org, Tony Lindgren,
Javier Martinez Canillas
Hi Enric,
On 10/09/2013 17:38, Enric Balletbo Serra wrote:
> 2013/9/10 Enric Balletbo i Serra <eballetbo@gmail.com>:
>> Add pinmux configuration for MCBSP2 connected to the TDM interface. With
>> this configuration the Headset modules works as expected.
>>
>> Signed-off-by: Enric Balletbo i Serra <eballetbo@gmail.com>
>> Acked-by: Javier Martinez Canillas <javier@dowhile0.org>
>> ---
>> arch/arm/boot/dts/omap3-igep.dtsi | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi
>> index bc48b11..2326d11 100644
>> --- a/arch/arm/boot/dts/omap3-igep.dtsi
>> +++ b/arch/arm/boot/dts/omap3-igep.dtsi
>> @@ -48,6 +48,15 @@
>> >;
>> };
>>
>> + mcbsp2_pins: pinmux_mcbsp2_pins {
>> + pinctrl-single,pins = <
>> + 0x10c (PIN_INPUT | MUX_MODE0) /* mcbsp2_fsx.mcbsp2_fsx */
>> + 0x10e (PIN_INPUT | MUX_MODE0) /* mcbsp2_clkx.mcbsp2_clkx */
>> + 0x110 (PIN_INPUT | MUX_MODE0) /* mcbsp2_dr.mcbsp2.dr */
>> + 0x112 (PIN_OUTPUT | MUX_MODE0) /* mcbsp2_dx.mcbsp2_dx */
>> + >;
>> + };
>> +
>> mmc1_pins: pinmux_mmc1_pins {
>> pinctrl-single,pins = <
>> 0x114 (PIN_INPUT_PULLUP | MUX_MODE0) /* sdmmc1_clk.sdmmc1_clk */
>> @@ -93,6 +102,11 @@
>> clock-frequency = <400000>;
>> };
>>
>> +&mcbsp2 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&mcbsp2_pins>;
>> +};
>> +
>> &mmc1 {
>> pinctrl-names = "default";
>> pinctrl-0 = <&mmc1_pins>;
>> --
>> 1.8.1.2
>>
>
> Hi Benoit,
>
> I sent this patch some time ago to be merged as a fix for 3.11, but
> seems was not merged. Would be possible include this patch in these
> series ?
I'm really sorry I missed that one :-(
I'm applying it right now, and will update my pull request.
Thanks,
Benoit
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: dts: igep00x0: Add pinmux configuration for MCBSP2.
2013-09-18 12:33 ` Benoit Cousson
@ 2013-09-19 6:31 ` Enric Balletbo Serra
0 siblings, 0 replies; 7+ messages in thread
From: Enric Balletbo Serra @ 2013-09-19 6:31 UTC (permalink / raw)
To: Benoit Cousson
Cc: linux-omap@vger.kernel.org, Tony Lindgren,
Javier Martinez Canillas
Hi Benoit,
2013/9/18 Benoit Cousson <bcousson@baylibre.com>:
> Hi Enric,
>
>
> On 10/09/2013 17:38, Enric Balletbo Serra wrote:
>>
>> 2013/9/10 Enric Balletbo i Serra <eballetbo@gmail.com>:
>>>
>>> Add pinmux configuration for MCBSP2 connected to the TDM interface. With
>>> this configuration the Headset modules works as expected.
>>>
>>> Signed-off-by: Enric Balletbo i Serra <eballetbo@gmail.com>
>>> Acked-by: Javier Martinez Canillas <javier@dowhile0.org>
>>> ---
>>> arch/arm/boot/dts/omap3-igep.dtsi | 14 ++++++++++++++
>>> 1 file changed, 14 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/omap3-igep.dtsi
>>> b/arch/arm/boot/dts/omap3-igep.dtsi
>>> index bc48b11..2326d11 100644
>>> --- a/arch/arm/boot/dts/omap3-igep.dtsi
>>> +++ b/arch/arm/boot/dts/omap3-igep.dtsi
>>> @@ -48,6 +48,15 @@
>>> >;
>>> };
>>>
>>> + mcbsp2_pins: pinmux_mcbsp2_pins {
>>> + pinctrl-single,pins = <
>>> + 0x10c (PIN_INPUT | MUX_MODE0) /*
>>> mcbsp2_fsx.mcbsp2_fsx */
>>> + 0x10e (PIN_INPUT | MUX_MODE0) /*
>>> mcbsp2_clkx.mcbsp2_clkx */
>>> + 0x110 (PIN_INPUT | MUX_MODE0) /*
>>> mcbsp2_dr.mcbsp2.dr */
>>> + 0x112 (PIN_OUTPUT | MUX_MODE0) /*
>>> mcbsp2_dx.mcbsp2_dx */
>>> + >;
>>> + };
>>> +
>>> mmc1_pins: pinmux_mmc1_pins {
>>> pinctrl-single,pins = <
>>> 0x114 (PIN_INPUT_PULLUP | MUX_MODE0) /*
>>> sdmmc1_clk.sdmmc1_clk */
>>> @@ -93,6 +102,11 @@
>>> clock-frequency = <400000>;
>>> };
>>>
>>> +&mcbsp2 {
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&mcbsp2_pins>;
>>> +};
>>> +
>>> &mmc1 {
>>> pinctrl-names = "default";
>>> pinctrl-0 = <&mmc1_pins>;
>>> --
>>> 1.8.1.2
>>>
>>
>> Hi Benoit,
>>
>> I sent this patch some time ago to be merged as a fix for 3.11, but
>> seems was not merged. Would be possible include this patch in these
>> series ?
>
>
> I'm really sorry I missed that one :-(
> I'm applying it right now, and will update my pull request.
>
> Thanks,
> Benoit
>
Many thanks.
Best regards,
Enric
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] ARM: dts: igep00x0: Add pinmux configuration for MCBSP2.
@ 2013-07-06 9:42 Javier Martinez Canillas
2013-07-10 8:07 ` Enric Balletbo Serra
0 siblings, 1 reply; 7+ messages in thread
From: Javier Martinez Canillas @ 2013-07-06 9:42 UTC (permalink / raw)
To: Enric Balletbo i Serra, Benoît Cousson, Tony Lindgren,
linux-omap
On Fri, Jul 5, 2013 at 11:38 PM, Enric Balletbo i Serra
<eballetbo@gmail.com> wrote:
> IGEP Processor Boards based on OMAP3 have the MCBSP2 connected to the TDM
> interface. The kernel should configure the pinmux for these pins in order
> to get TWL4030 codec working. Without this, for example, playing a wav file
> doesn't work.
>
> Signed-off-by: Enric Balletbo i Serra <eballetbo@gmail.com>
> ---
> arch/arm/boot/dts/omap3-igep.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi
> index bc48b11..2326d11 100644
> --- a/arch/arm/boot/dts/omap3-igep.dtsi
> +++ b/arch/arm/boot/dts/omap3-igep.dtsi
> @@ -48,6 +48,15 @@
> >;
> };
>
> + mcbsp2_pins: pinmux_mcbsp2_pins {
> + pinctrl-single,pins = <
> + 0x10c (PIN_INPUT | MUX_MODE0) /* mcbsp2_fsx.mcbsp2_fsx */
> + 0x10e (PIN_INPUT | MUX_MODE0) /* mcbsp2_clkx.mcbsp2_clkx */
> + 0x110 (PIN_INPUT | MUX_MODE0) /* mcbsp2_dr.mcbsp2.dr */
> + 0x112 (PIN_OUTPUT | MUX_MODE0) /* mcbsp2_dx.mcbsp2_dx */
> + >;
> + };
> +
> mmc1_pins: pinmux_mmc1_pins {
> pinctrl-single,pins = <
> 0x114 (PIN_INPUT_PULLUP | MUX_MODE0) /* sdmmc1_clk.sdmmc1_clk */
> @@ -93,6 +102,11 @@
> clock-frequency = <400000>;
> };
>
> +&mcbsp2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&mcbsp2_pins>;
> +};
> +
> &mmc1 {
> pinctrl-names = "default";
> pinctrl-0 = <&mmc1_pins>;
> --
> 1.8.1.2
>
Acked-by: Javier Martinez Canillas <javier@dowhile0.org>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] ARM: dts: igep00x0: Add pinmux configuration for MCBSP2.
2013-07-06 9:42 Javier Martinez Canillas
@ 2013-07-10 8:07 ` Enric Balletbo Serra
0 siblings, 0 replies; 7+ messages in thread
From: Enric Balletbo Serra @ 2013-07-10 8:07 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: Benoît Cousson, Tony Lindgren, linux-omap
Hi Benoit,
2013/7/6 Javier Martinez Canillas <javier@dowhile0.org>:
> On Fri, Jul 5, 2013 at 11:38 PM, Enric Balletbo i Serra
> <eballetbo@gmail.com> wrote:
>> IGEP Processor Boards based on OMAP3 have the MCBSP2 connected to the TDM
>> interface. The kernel should configure the pinmux for these pins in order
>> to get TWL4030 codec working. Without this, for example, playing a wav file
>> doesn't work.
>>
>> Signed-off-by: Enric Balletbo i Serra <eballetbo@gmail.com>
>> ---
>> arch/arm/boot/dts/omap3-igep.dtsi | 14 ++++++++++++++
>> 1 file changed, 14 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi
>> index bc48b11..2326d11 100644
>> --- a/arch/arm/boot/dts/omap3-igep.dtsi
>> +++ b/arch/arm/boot/dts/omap3-igep.dtsi
>> @@ -48,6 +48,15 @@
>> >;
>> };
>>
>> + mcbsp2_pins: pinmux_mcbsp2_pins {
>> + pinctrl-single,pins = <
>> + 0x10c (PIN_INPUT | MUX_MODE0) /* mcbsp2_fsx.mcbsp2_fsx */
>> + 0x10e (PIN_INPUT | MUX_MODE0) /* mcbsp2_clkx.mcbsp2_clkx */
>> + 0x110 (PIN_INPUT | MUX_MODE0) /* mcbsp2_dr.mcbsp2.dr */
>> + 0x112 (PIN_OUTPUT | MUX_MODE0) /* mcbsp2_dx.mcbsp2_dx */
>> + >;
>> + };
>> +
>> mmc1_pins: pinmux_mmc1_pins {
>> pinctrl-single,pins = <
>> 0x114 (PIN_INPUT_PULLUP | MUX_MODE0) /* sdmmc1_clk.sdmmc1_clk */
>> @@ -93,6 +102,11 @@
>> clock-frequency = <400000>;
>> };
>>
>> +&mcbsp2 {
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&mcbsp2_pins>;
>> +};
>> +
>> &mmc1 {
>> pinctrl-names = "default";
>> pinctrl-0 = <&mmc1_pins>;
>> --
>> 1.8.1.2
>>
>
> Acked-by: Javier Martinez Canillas <javier@dowhile0.org>
As this is a fix and without this the audio interface doesn't work,
it's possible to add this patch for v3.11 merge window ?
Thanks,
Enric
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] ARM: dts: igep00x0: Add pinmux configuration for MCBSP2.
@ 2013-07-05 21:38 Enric Balletbo i Serra
0 siblings, 0 replies; 7+ messages in thread
From: Enric Balletbo i Serra @ 2013-07-05 21:38 UTC (permalink / raw)
To: Benoît Cousson, Tony Lindgren, Javier Martinez Canillas,
linux-omap
Cc: Enric Balletbo i Serra
IGEP Processor Boards based on OMAP3 have the MCBSP2 connected to the TDM
interface. The kernel should configure the pinmux for these pins in order
to get TWL4030 codec working. Without this, for example, playing a wav file
doesn't work.
Signed-off-by: Enric Balletbo i Serra <eballetbo@gmail.com>
---
arch/arm/boot/dts/omap3-igep.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi
index bc48b11..2326d11 100644
--- a/arch/arm/boot/dts/omap3-igep.dtsi
+++ b/arch/arm/boot/dts/omap3-igep.dtsi
@@ -48,6 +48,15 @@
>;
};
+ mcbsp2_pins: pinmux_mcbsp2_pins {
+ pinctrl-single,pins = <
+ 0x10c (PIN_INPUT | MUX_MODE0) /* mcbsp2_fsx.mcbsp2_fsx */
+ 0x10e (PIN_INPUT | MUX_MODE0) /* mcbsp2_clkx.mcbsp2_clkx */
+ 0x110 (PIN_INPUT | MUX_MODE0) /* mcbsp2_dr.mcbsp2.dr */
+ 0x112 (PIN_OUTPUT | MUX_MODE0) /* mcbsp2_dx.mcbsp2_dx */
+ >;
+ };
+
mmc1_pins: pinmux_mmc1_pins {
pinctrl-single,pins = <
0x114 (PIN_INPUT_PULLUP | MUX_MODE0) /* sdmmc1_clk.sdmmc1_clk */
@@ -93,6 +102,11 @@
clock-frequency = <400000>;
};
+&mcbsp2 {
+ pinctrl-names = "default";
+ pinctrl-0 = <&mcbsp2_pins>;
+};
+
&mmc1 {
pinctrl-names = "default";
pinctrl-0 = <&mmc1_pins>;
--
1.8.1.2
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-09-19 6:31 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-10 15:35 [PATCH] ARM: dts: igep00x0: Add pinmux configuration for MCBSP2 Enric Balletbo i Serra
2013-09-10 15:38 ` Enric Balletbo Serra
2013-09-18 12:33 ` Benoit Cousson
2013-09-19 6:31 ` Enric Balletbo Serra
-- strict thread matches above, loose matches on Subject: below --
2013-07-06 9:42 Javier Martinez Canillas
2013-07-10 8:07 ` Enric Balletbo Serra
2013-07-05 21:38 Enric Balletbo i Serra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).