From: Archit Taneja <archit@ti.com>
To: tomi.valkeinen@ti.com, tony@atomide.com
Cc: linux-omap@vger.kernel.org, Archit Taneja <archit@ti.com>,
Andy Gross <andygro@gmail.com>
Subject: [PATCH v2 1/4] arm: omap: drm: Don't build device for DMM
Date: Mon, 16 Sep 2013 12:48:28 +0530 [thread overview]
Message-ID: <1379315911-24634-2-git-send-email-archit@ti.com> (raw)
In-Reply-To: <1379315911-24634-1-git-send-email-archit@ti.com>
DMM exists on omap4+ platforms, these platforms are always expected to boot with
DT. Remove the current method of searching the dmm hwmod and building an
omap_device for dmm.
For OMAP4, the address and irq data for DMM hwmod(along with other blocks) were
removed, so the current method fails in the dmm driver's probe anyway.
The addition of DMM nodes in DT will ensure that a DMM device is built
correctly.
Cc: Andy Gross <andygro@gmail.com>
Signed-off-by: Archit Taneja <archit@ti.com>
---
arch/arm/mach-omap2/drm.c | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/arch/arm/mach-omap2/drm.c b/arch/arm/mach-omap2/drm.c
index 59a4af7..e6c38cd 100644
--- a/arch/arm/mach-omap2/drm.c
+++ b/arch/arm/mach-omap2/drm.c
@@ -26,8 +26,6 @@
#include <linux/platform_data/omap_drm.h>
#include "soc.h"
-#include "omap_device.h"
-#include "omap_hwmod.h"
#if defined(CONFIG_DRM_OMAP) || (CONFIG_DRM_OMAP_MODULE)
@@ -44,18 +42,6 @@ static struct platform_device omap_drm_device = {
static int __init omap_init_drm(void)
{
- struct omap_hwmod *oh = NULL;
- struct platform_device *pdev;
-
- /* lookup and populate the DMM information, if present - OMAP4+ */
- oh = omap_hwmod_lookup("dmm");
-
- if (oh) {
- pdev = omap_device_build(oh->name, -1, oh, NULL, 0);
- WARN(IS_ERR(pdev), "Could not build omap_device for %s\n",
- oh->name);
- }
-
platform_data.omaprev = GET_OMAP_TYPE;
return platform_device_register(&omap_drm_device);
--
1.8.1.2
next prev parent reply other threads:[~2013-09-16 7:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 7:18 [PATCH v2 0/4] arm: omap: display: Ensure DRM/FB/V4L devices are created if DSS is available Archit Taneja
2013-09-16 7:18 ` Archit Taneja [this message]
2013-09-16 7:18 ` [PATCH v2 2/4] arm: omap: display: Create omapdrm device inside omap_display_init Archit Taneja
2013-09-16 7:18 ` [PATCH v2 3/4] arm: omap: display: Create omapvrfb and omapfb devices " Archit Taneja
2013-09-16 7:18 ` [PATCH v2 4/4] arm: omap: display: Create omap_vout device " Archit Taneja
2013-09-16 8:50 ` [PATCH v2 0/4] arm: omap: display: Ensure DRM/FB/V4L devices are created if DSS is available Tomi Valkeinen
2013-10-08 21:06 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379315911-24634-2-git-send-email-archit@ti.com \
--to=archit@ti.com \
--cc=andygro@gmail.com \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).