From: Daniel Mack <zonque@gmail.com>
To: linux-ubs@vger.kernel.org
Cc: balbi@ti.com, linux-omap@vger.kernel.org,
gregkh@linuxfoundation.org, Daniel Mack <zonque@gmail.com>
Subject: [PATCH 1/4] usb: musb: am35x: use SIMPLE_DEV_PM_OPS
Date: Sun, 22 Sep 2013 13:46:58 +0200 [thread overview]
Message-ID: <1379850421-7966-1-git-send-email-zonque@gmail.com> (raw)
This makes am35x_pm_ops const.
Also, checkpatch.pl complains about the use of DEV_PM_OPS:
ERROR: Macros with complex values should be enclosed in parenthesis
Signed-off-by: Daniel Mack <zonque@gmail.com>
---
drivers/usb/musb/am35x.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/musb/am35x.c b/drivers/usb/musb/am35x.c
index 5c310c6..df32a29 100644
--- a/drivers/usb/musb/am35x.c
+++ b/drivers/usb/musb/am35x.c
@@ -616,12 +616,9 @@ static int am35x_resume(struct device *dev)
return 0;
}
-static struct dev_pm_ops am35x_pm_ops = {
- .suspend = am35x_suspend,
- .resume = am35x_resume,
-};
+static SIMPLE_DEV_PM_OPS(am35x_pm_ops, am35x_suspend, am35x_resume);
-#define DEV_PM_OPS &am35x_pm_ops
+#define DEV_PM_OPS (&am35x_pm_ops)
#else
#define DEV_PM_OPS NULL
#endif
--
1.8.3.1
next reply other threads:[~2013-09-22 11:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-22 11:46 Daniel Mack [this message]
2013-09-22 11:46 ` [PATCH 2/4] usb: musb: blackfin: use SIMPLE_DEV_PM_OPS Daniel Mack
2013-09-22 11:47 ` [PATCH 3/4] usb: musb: omap2430: " Daniel Mack
2013-09-22 11:47 ` [PATCH 4/4] usb: musb: ux500: " Daniel Mack
2013-09-23 21:20 ` [PATCH 1/4] usb: musb: am35x: " Felipe Balbi
2013-09-24 6:57 ` Daniel Mack
2013-09-25 13:48 ` Felipe Balbi
2013-09-27 18:47 ` Daniel Mack
2013-09-30 16:25 ` Felipe Balbi
2013-09-30 16:56 ` Daniel Mack
2013-10-02 8:10 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379850421-7966-1-git-send-email-zonque@gmail.com \
--to=zonque@gmail.com \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-ubs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).