From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: balbi@ti.com, rob.herring@calxeda.com, pawel.moll@arm.com,
mark.rutland@arm.com, ian.campbell@citrix.com, rob@landley.net,
gregkh@linuxfoundation.org, grant.likely@linaro.org,
idos@codeaurora.org, mgautam@codeaurora.org,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v5 1/3] usb: dwc3: msm: Add device tree binding information
Date: Tue, 01 Oct 2013 15:05:14 +0300 [thread overview]
Message-ID: <1380629114.30666.19.camel@iivanov-dev.int.mm-sol.com> (raw)
In-Reply-To: <5240BAA6.9090509@wwwdotorg.org>
Hi,
On Mon, 2013-09-23 at 16:03 -0600, Stephen Warren wrote:
> On 09/23/2013 01:32 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Wed, Aug 21, 2013 at 04:29:44PM +0300, Ivan T. Ivanov wrote:
> >> From: "Ivan T. Ivanov" <iivanov@mm-sol.com>
> >>
> >> MSM USB3.0 core wrapper consist of USB3.0 IP from Synopsys (SNPS)
> >> and HS, SS PHY's control and configuration registers.
> >>
> >> It could operate in device mode (SS, HS, FS) and host mode (SS,
> >> HS, FS, LS).
> >>
> >> Signed-off-by: Ivan T. Ivanov <iivanov@mm-sol.com>
> >
> > and here's a new version from same patch
>
> The binding looks pretty simple, so I don't think it's too contentious.
>
> >> diff --git a/Documentation/devicetree/bindings/usb/msm-ssusb.txt
> >> b/Documentation/devicetree/bindings/usb/msm-ssusb.txt
>
> >> +MSM DWC3 controller wrapper
>
> >> +Optional properties : +- gdsc-supply : phandle to the globally
> >> distributed switch controller + regulator node to the USB
> >> controller.
>
> If that's a regulator node, why not use xxx-supply properties to
> interface with it?
That was the intention. What about:
Optional "supply-name" :
"gdsc" - supply from globally distributed switch controller
>
> Aside from that, the binding,
> Acked-by: Stephen Warren <swarren@nvidia.com>
Thank you.
Regards,
Ivan
next prev parent reply other threads:[~2013-10-01 12:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-21 13:29 [PATCH v5 0/3] DWC3 USB support for Qualcomm platform Ivan T. Ivanov
2013-08-21 13:29 ` [PATCH v5 1/3] usb: dwc3: msm: Add device tree binding information Ivan T. Ivanov
2013-09-23 19:32 ` Felipe Balbi
2013-09-23 22:03 ` Stephen Warren
2013-10-01 12:05 ` Ivan T. Ivanov [this message]
2013-10-01 12:08 ` Ivan T. Ivanov
2013-10-04 14:31 ` Felipe Balbi
2013-10-07 7:57 ` Ivan T. Ivanov
[not found] ` <1377091786-5613-1-git-send-email-iivanov-NEYub+7Iv8PQT0dZR+AlfA@public.gmane.org>
2013-08-21 13:29 ` [PATCH v5 2/3] usb: phy: Add Qualcomm SS-USB and HS-USB drivers for DW PHY's Ivan T. Ivanov
2013-09-23 19:32 ` Felipe Balbi
2013-08-21 13:29 ` [PATCH v5 3/3] usb: dwc3: Add Qualcomm DWC3 glue layer driver Ivan T. Ivanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380629114.30666.19.camel@iivanov-dev.int.mm-sol.com \
--to=iivanov@mm-sol.com \
--cc=akpm@linux-foundation.org \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=ian.campbell@citrix.com \
--cc=idos@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mgautam@codeaurora.org \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).