linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Varun B Patil <varun.basavaraj.patil@gmail.com>
To: linux-omap@vger.kernel.org
Cc: Varun B Patil <varun.basavaraj.patil@gmail.com>
Subject: [PATCH] omapdce : fix transaction corruption due to wrong request id
Date: Sun,  6 Oct 2013 18:38:47 +0530	[thread overview]
Message-ID: <1381064927-3798-3-git-send-email-varun.basavaraj.patil@gmail.com> (raw)
In-Reply-To: <1381064927-3798-1-git-send-email-varun.basavaraj.patil@gmail.com>

ioctl_codec_process was calling get_paddr() with a wrong pointer as
argument which resulted in wrong req_id being used to get the transaction
inside get_paddr().

Signed-off-by: Varun B Patil <varun.basavaraj.patil@gmail.com>
---
 drivers/staging/omapdce/dce.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/omapdce/dce.c b/drivers/staging/omapdce/dce.c
index 87a45fa..2a7cbef 100644
--- a/drivers/staging/omapdce/dce.c
+++ b/drivers/staging/omapdce/dce.c
@@ -1296,7 +1296,7 @@ static int ioctl_codec_process(struct drm_device *dev, void *data,
 
 		codec_get_quirks(priv, arg->codec_handle, &quirks);
 
-		ret = PTR_RET(get_paddr(priv, hdr(&req), &req->out_args, arg->out_args_bo));
+		ret = PTR_RET(get_paddr(priv, hdr(req), &req->out_args, arg->out_args_bo));
 		if (ret)
 			return rpabort(hdr(req), ret);
 
-- 
1.8.1.2


      parent reply	other threads:[~2013-10-06 13:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-06 13:08 [PATCH] omapdce : clear transaction if engine_open rpsend fails Varun B Patil
2013-10-06 13:08 ` [PATCH] omapdce : fix bug in ioctl_codec_process Varun B Patil
2013-10-06 13:08 ` Varun B Patil [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381064927-3798-3-git-send-email-varun.basavaraj.patil@gmail.com \
    --to=varun.basavaraj.patil@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).