Re: [RFT/RFC/PATCH 00/31] arm: omap: irq: cleanup INTC driver

Felipe Balbi
2013-12-23T17:35:18Z

[-- Attachment #1: Type: text/plain, Size: 2017 bytes --]

On Fri, Dec 20, 2013 at 04:53:09PM -0800, Tony Lindgren wrote:
> * Felipe Balbi <balbi@ti.com> [131219 15:23]:
> > On Thu, Dec 19, 2013 at 10:48:15AM -0800, Tony Lindgren wrote:
> > > * Felipe Balbi <balbi@ti.com> [131120 10:10]:
> > > > Afte these patches, we're very close to being able
> > > > to move arch/arm/mach-omap2/irq.c to drivers/irqchip/irq-intc.c
> > >
> > > That would be nice :)
> > >
> > > > All which would be missing is for Tony to drop all OMAP2/3 board
> > > > files so we remove the few pending bits and pieces left in
> > > > for legacy boot.
> > >
> > > That may still need to wait a while, but let's see.
> > >
> > > > Note that I have only boot tested these on AM335x Bone Black
> > > > (with a small fix for fixed regulator which should be in
> > > > the mailing list already), so I'd need help testing all
> > > > other impacted platforms, specially when it comes to PM.
> > >
> > > Sorry have not had much of a chance to test these with PM with
> > > all the fixes needed for omap3 DT mode. Tried testing these
> > > just now, but I get:
> > >
> > > arch/arm/mach-omap2/board-generic.c:134: error: ‘omap_intc_of_init’ undeclared here (not in a function)
> >
> > some of your other changes messed it up, I have not references of
> > omap_intc_of_init() in my branch, because that's one of the things I'm
> > dropping from DT-based boots.
> >
> > Can you see which patch added a new omap_intc_of_init() call ? Or maybe
> > tell me which branch I should rebase on top of ?
>
> OK I tried against v3.13-rc4, it's the 3517 changes that caused
> it. Looks like that can be just removed, and then there are some
> trivial n8x0 merge conflicts. And n8x0 boots too.
>
> But looks like omap3 off-idle hangs after hitting idle with these,

could it be we're racing between irq_chip.suspend() and hwmod's
_disable() calls ?

> so a bit more work is needed. Maybe also rebase these against
> omap-for-v3.14/dt too?

Will do.

--
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]