linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: bcousson@baylibre.com, paul@pwsan.com, tony@atomide.com
Cc: tomi.valkeinen@ti.com, balbi@ti.com, sr@denx.de,
	David.Laight@ACULAB.COM, michael@amarulasolutions.com,
	bigeasy@linutronix.de, linux-omap@vger.kernel.org,
	linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Roger Quadros <rogerq@ti.com>
Subject: [PATCH 3/3] ARM: OMAP3: hwmod data: Don't prevent RESET of USB Host module
Date: Tue, 3 Dec 2013 16:25:48 +0200	[thread overview]
Message-ID: <1386080748-17005-4-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1386080748-17005-1-git-send-email-rogerq@ti.com>

Unlike what the comment states, errata i660 does not state that we
can't RESET the USB host module. Instead it states that RESET is the
only way to recover from a deadlock situation.

RESET ensures that the module is in a known good state irrespective
of what bootloader does with the module, so it must be done at boot.

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
index 9e56fab..d337429 100644
--- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
@@ -1943,7 +1943,8 @@ static struct omap_hwmod_class_sysconfig omap3xxx_usb_host_hs_sysc = {
 	.syss_offs	= 0x0014,
 	.sysc_flags	= (SYSC_HAS_MIDLEMODE | SYSC_HAS_CLOCKACTIVITY |
 			   SYSC_HAS_SIDLEMODE | SYSC_HAS_ENAWAKEUP |
-			   SYSC_HAS_SOFTRESET | SYSC_HAS_AUTOIDLE),
+			   SYSC_HAS_SOFTRESET | SYSC_HAS_AUTOIDLE |
+			   SYSS_HAS_RESET_STATUS),
 	.idlemodes	= (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART |
 			   MSTANDBY_FORCE | MSTANDBY_NO | MSTANDBY_SMART),
 	.sysc_fields	= &omap_hwmod_sysc_type1,
@@ -2021,15 +2022,7 @@ static struct omap_hwmod omap3xxx_usb_host_hs_hwmod = {
 	 * hence HWMOD_SWSUP_MSTANDBY
 	 */
 
-	/*
-	 * During system boot; If the hwmod framework resets the module
-	 * the module will have smart idle settings; which can lead to deadlock
-	 * (above Errata Id:i660); so, dont reset the module during boot;
-	 * Use HWMOD_INIT_NO_RESET.
-	 */
-
-	.flags		= HWMOD_SWSUP_SIDLE | HWMOD_SWSUP_MSTANDBY |
-			  HWMOD_INIT_NO_RESET,
+	.flags		= HWMOD_SWSUP_SIDLE | HWMOD_SWSUP_MSTANDBY,
 };
 
 /*
-- 
1.8.3.2

  parent reply	other threads:[~2013-12-03 14:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-03 14:25 [PATCH v2 0/3] ARM: OMAP2+: USB Host bug fixes for 3.13 rc Roger Quadros
2013-12-03 14:25 ` [PATCH 1/3] ARM: OMAP4+: hwmod data: Don't prevent RESET of USB Host module Roger Quadros
     [not found]   ` <1386080748-17005-2-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2013-12-09  1:26     ` Paul Walmsley
2013-12-09  1:58       ` Tony Lindgren
2013-12-09  2:15         ` Paul Walmsley
2013-12-09 17:52       ` Benoit Cousson
2013-12-03 14:25 ` [PATCH 2/3] ARM: OMAP2+: hwmod: Fix RESET logic Roger Quadros
2013-12-09  1:32   ` Paul Walmsley
2013-12-03 14:25 ` Roger Quadros [this message]
2013-12-09  1:34   ` [PATCH 3/3] ARM: OMAP3: hwmod data: Don't prevent RESET of USB Host module Paul Walmsley
2013-12-04 10:00 ` [PATCH v2 0/3] ARM: OMAP2+: USB Host bug fixes for 3.13 rc Tomi Valkeinen
2013-12-05 18:48   ` Tony Lindgren
2013-12-06  9:14     ` Roger Quadros
     [not found]   ` <529EFD42.9070507-l0cyMroinI0@public.gmane.org>
2013-12-09  1:35     ` Paul Walmsley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386080748-17005-4-git-send-email-rogerq@ti.com \
    --to=rogerq@ti.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=balbi@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=bigeasy@linutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=michael@amarulasolutions.com \
    --cc=paul@pwsan.com \
    --cc=sr@denx.de \
    --cc=tomi.valkeinen@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).