From: Felipe Balbi <balbi@ti.com>
To: lee.jones@linaro.org
Cc: Tony Lindgren <tony@atomide.com>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Felipe Balbi <balbi@ti.com>
Subject: [PATCH v3 10/15] mfd: menelaus: Pass menelaus_chip argument to menelaus <-> time helpers
Date: Mon, 9 Dec 2013 10:21:20 -0600 [thread overview]
Message-ID: <1386606085-26838-10-git-send-email-balbi@ti.com> (raw)
In-Reply-To: <1386606085-26838-1-git-send-email-balbi@ti.com>
time_to_menelaus() and menelaus_to_time() are static and can easily
receive a struct menelaus_chip pointer argument.
After this patch, the_menelaus is only used on exported functions which
are currently being used by board-n8x0.c.
Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi>
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
drivers/mfd/menelaus.c | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c
index 13d1cb0..aa3c579 100644
--- a/drivers/mfd/menelaus.c
+++ b/drivers/mfd/menelaus.c
@@ -857,10 +857,9 @@ static irqreturn_t menelaus_irq(int irq, void *_menelaus)
#define RTC_HR_PM (1 << 7)
-static void menelaus_to_time(char *regs, struct rtc_time *t)
+static void menelaus_to_time(struct menelaus_chip *m,
+ char *regs, struct rtc_time *t)
{
- struct menelaus_chip *m = the_menelaus;
-
t->tm_sec = bcd2bin(regs[0]);
t->tm_min = bcd2bin(regs[1]);
if (m->rtc_control & RTC_CTRL_MODE12) {
@@ -874,9 +873,9 @@ static void menelaus_to_time(char *regs, struct rtc_time *t)
t->tm_year = bcd2bin(regs[5]) + 100;
}
-static int time_to_menelaus(struct rtc_time *t, int regnum)
+static int time_to_menelaus(struct menelaus_chip *m,
+ struct rtc_time *t, int regnum)
{
- struct menelaus_chip *m = the_menelaus;
int hour, status;
status = menelaus_write_reg(m, regnum++, bin2bcd(t->tm_sec));
@@ -944,7 +943,7 @@ static int menelaus_read_time(struct device *dev, struct rtc_time *t)
return -EIO;
}
- menelaus_to_time(regs, t);
+ menelaus_to_time(m, regs, t);
t->tm_wday = bcd2bin(regs[6]);
return 0;
@@ -956,7 +955,7 @@ static int menelaus_set_time(struct device *dev, struct rtc_time *t)
int status;
/* write date and time registers */
- status = time_to_menelaus(t, MENELAUS_RTC_SEC);
+ status = time_to_menelaus(m, t, MENELAUS_RTC_SEC);
if (status < 0)
return status;
status = menelaus_write_reg(m, MENELAUS_RTC_WKDAY, bin2bcd(t->tm_wday));
@@ -1001,7 +1000,7 @@ static int menelaus_read_alarm(struct device *dev, struct rtc_wkalrm *w)
return -EIO;
}
- menelaus_to_time(regs, &w->time);
+ menelaus_to_time(m, regs, &w->time);
w->enabled = !!(m->rtc_control & RTC_CTRL_AL_EN);
@@ -1029,7 +1028,7 @@ static int menelaus_set_alarm(struct device *dev, struct rtc_wkalrm *w)
}
/* write alarm registers */
- status = time_to_menelaus(&w->time, MENELAUS_RTC_AL_SEC);
+ status = time_to_menelaus(m, &w->time, MENELAUS_RTC_AL_SEC);
if (status < 0)
return status;
--
1.8.4.GIT
next prev parent reply other threads:[~2013-12-09 16:21 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 3:42 [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation Felipe Balbi
2013-12-03 3:42 ` [PATCH v2 02/15] mfd: menelaus: Switch over to module_i2c_driver Felipe Balbi
2013-12-03 3:42 ` [PATCH v2 03/15] mfd: menelaus: Convert to threaded irq Felipe Balbi
2013-12-03 3:42 ` [PATCH v2 04/15] mfd: menelaus: Remove unnecessary loop Felipe Balbi
2013-12-03 3:42 ` [PATCH v2 05/15] mfd: menelaus: Use for_each_set_bit() Felipe Balbi
2013-12-03 3:42 ` [PATCH v2 06/15] mfd: menelaus: Pass menelaus pointer as argument to enable/disable irq Felipe Balbi
2013-12-03 3:43 ` [PATCH v2 07/15] mfd: menelaus: Limit the usage of the_menelaus Felipe Balbi
2013-12-03 3:43 ` [PATCH v2 08/15] mfd: menelaus: Pass menelaus_chip pointer to add/remove irq functions Felipe Balbi
2013-12-03 3:43 ` [PATCH v2 09/15] mfd: menelaus: Pass menelaus_chip pointer to get/set voltage Felipe Balbi
2013-12-03 3:43 ` [PATCH v2 10/15] mfd: menelaus: Pass menelaus_chip argument to menelaus <-> time helpers Felipe Balbi
2013-12-03 3:43 ` [PATCH v2 11/15] mfd: menelaus: Start to use irqdomain Felipe Balbi
2013-12-03 3:43 ` [PATCH v2 12/15] mfd: menelaus: Switch all children to threaded_irq Felipe Balbi
2013-12-03 3:43 ` [PATCH v2 13/15] mfd: menelaus: Remove unnecessary definition Felipe Balbi
2013-12-03 3:43 ` [PATCH v2 14/15] mfd: menelaus: IRQ is a requirement Felipe Balbi
2013-12-03 3:43 ` [PATCH v2 15/15] mfd: menelaus: Use devm_request_threaded_irq() Felipe Balbi
2013-12-03 9:51 ` [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation Lee Jones
2013-12-03 9:53 ` Lee Jones
2013-12-08 19:07 ` Felipe Balbi
2013-12-09 9:37 ` Lee Jones
2013-12-09 16:14 ` Felipe Balbi
2013-12-09 16:21 ` [PATCH v3 " Felipe Balbi
2013-12-09 16:21 ` [PATCH v3 02/15] mfd: menelaus: Switch over to module_i2c_driver Felipe Balbi
2013-12-09 16:21 ` [PATCH v3 03/15] mfd: menelaus: Convert to threaded irq Felipe Balbi
2013-12-10 9:32 ` Lee Jones
2013-12-10 16:31 ` Felipe Balbi
2013-12-09 16:21 ` [PATCH v3 04/15] mfd: menelaus: Remove unnecessary loop Felipe Balbi
2013-12-09 16:21 ` [PATCH v3 05/15] mfd: menelaus: Use for_each_set_bit() Felipe Balbi
2013-12-09 16:21 ` [PATCH v3 06/15] mfd: menelaus: Pass menelaus pointer as argument to enable/disable irq Felipe Balbi
2013-12-09 16:21 ` [PATCH v3 07/15] mfd: menelaus: Limit the usage of the_menelaus Felipe Balbi
2013-12-10 8:57 ` Lee Jones
2013-12-10 16:32 ` Felipe Balbi
2013-12-11 9:17 ` Lee Jones
2013-12-09 16:21 ` [PATCH v3 08/15] mfd: menelaus: Pass menelaus_chip pointer to add/remove irq functions Felipe Balbi
2013-12-10 9:00 ` Lee Jones
2013-12-10 16:32 ` Felipe Balbi
2013-12-10 18:42 ` Lee Jones
2013-12-09 16:21 ` [PATCH v3 09/15] mfd: menelaus: Pass menelaus_chip pointer to get/set voltage Felipe Balbi
2013-12-10 9:01 ` Lee Jones
2013-12-09 16:21 ` Felipe Balbi [this message]
2013-12-10 9:02 ` [PATCH v3 10/15] mfd: menelaus: Pass menelaus_chip argument to menelaus <-> time helpers Lee Jones
2013-12-09 16:21 ` [PATCH v3 11/15] mfd: menelaus: Start to use irqdomain Felipe Balbi
2013-12-10 9:20 ` Lee Jones
2013-12-10 16:34 ` Felipe Balbi
2013-12-10 18:37 ` Lee Jones
2013-12-10 18:46 ` Tony Lindgren
2013-12-11 9:06 ` Lee Jones
2013-12-09 16:21 ` [PATCH v3 12/15] mfd: menelaus: Switch all children to threaded_irq Felipe Balbi
2013-12-09 16:21 ` [PATCH v3 13/15] mfd: menelaus: Remove unnecessary definition Felipe Balbi
2013-12-09 16:21 ` [PATCH v3 14/15] mfd: menelaus: IRQ is a requirement Felipe Balbi
2013-12-09 16:21 ` [PATCH v3 15/15] mfd: menelaus: Use devm_request_threaded_irq() Felipe Balbi
2013-12-10 9:30 ` Lee Jones
2013-12-10 16:34 ` Felipe Balbi
2013-12-10 18:32 ` Lee Jones
2013-12-11 9:48 ` [PATCH v3 01/15] mfd: menelaus: Drop __exit section annotation Uwe Kleine-König
2013-12-10 8:50 ` [PATCH v2 " Lee Jones
2013-12-10 16:36 ` Felipe Balbi
2013-12-06 13:41 ` Aaro Koskinen
2013-12-11 9:44 ` Uwe Kleine-König
2013-12-16 15:39 ` Lee Jones
2013-12-17 0:08 ` [PATCH 01/10] " Felipe Balbi
2013-12-17 0:08 ` [PATCH 02/10] mfd: menelaus: Switch over to module_i2c_driver Felipe Balbi
2013-12-17 0:08 ` [PATCH 03/10] mfd: menelaus: Convert to threaded irq Felipe Balbi
2013-12-17 0:08 ` [PATCH 04/10] mfd: menelaus: Remove unnecessary loop Felipe Balbi
2013-12-17 0:08 ` [PATCH 05/10] mfd: menelaus: Use for_each_set_bit() Felipe Balbi
2013-12-17 0:17 ` Joe Perches
2013-12-17 0:19 ` Felipe Balbi
2013-12-17 0:08 ` [PATCH 06/10] mfd: menelaus: Limit the usage of the_menelaus Felipe Balbi
2013-12-17 0:08 ` [PATCH 07/10] mfd: menelaus: Start to use irqdomain Felipe Balbi
2013-12-17 10:32 ` Lee Jones
2013-12-17 0:08 ` [PATCH 08/10] mfd: menelaus: Switch all children to threaded_irq Felipe Balbi
2013-12-17 10:35 ` Lee Jones
2013-12-17 0:08 ` [PATCH 09/10] mfd: menelaus: Remove unnecessary definition Felipe Balbi
2013-12-17 0:08 ` [PATCH 10/10] mfd: menelaus: IRQ is a requirement Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386606085-26838-10-git-send-email-balbi@ti.com \
--to=balbi@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).