From: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>
To: tomi.valkeinen@ti.com
Cc: tony@atomide.com, linux@arm.linux.org.uk, pali.rohar@gmail.com,
pavel@ucw.cz, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org,
Ivaylo Dimitrov <freemangordon@abv.bg>
Subject: [PATCH] ARM: omapfb: Add early framebuffer memory allocator
Date: Thu, 26 Dec 2013 01:12:39 +0200 [thread overview]
Message-ID: <1388013159-3036-1-git-send-email-ivo.g.dimitrov.75@gmail.com> (raw)
In-Reply-To: <52A062A0.3070005@ti.com>
From: Ivaylo Dimitrov <freemangordon@abv.bg>
On memory limited devices, CMA fails easily when asked to allocate big
chunks of memory like framebuffer memory needed for video playback.
Add boot parameter "omapfb_memsize" which allocates memory to be used
as dma coherent memory, so dma_alloc_attrs won't hit CMA allocator when
trying to allocate memory for the framebuffers
Signed-off-by: Ivaylo Dimitrov <freemangordon@abv.bg>
---
arch/arm/mach-omap2/common.c | 1 +
arch/arm/mach-omap2/common.h | 2 +
arch/arm/mach-omap2/fb.c | 46 +++++++++++++++++++++++++++++++++++++++++-
3 files changed, 48 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/common.c b/arch/arm/mach-omap2/common.c
index 2dabb9e..9beecde 100644
--- a/arch/arm/mach-omap2/common.c
+++ b/arch/arm/mach-omap2/common.c
@@ -33,4 +33,5 @@ void __init omap_reserve(void)
omap_dsp_reserve_sdram_memblock();
omap_secure_ram_reserve_memblock();
omap_barrier_reserve_memblock();
+ omap_fb_reserve_memblock();
}
diff --git a/arch/arm/mach-omap2/common.h b/arch/arm/mach-omap2/common.h
index e30ef67..21afdc0 100644
--- a/arch/arm/mach-omap2/common.h
+++ b/arch/arm/mach-omap2/common.h
@@ -304,6 +304,8 @@ extern void omap_reserve(void);
struct omap_hwmod;
extern int omap_dss_reset(struct omap_hwmod *);
+extern void omap_fb_reserve_memblock(void);
+
/* SoC specific clock initializer */
extern int (*omap_clk_init)(void);
diff --git a/arch/arm/mach-omap2/fb.c b/arch/arm/mach-omap2/fb.c
index 26e28e9..0eacbe9 100644
--- a/arch/arm/mach-omap2/fb.c
+++ b/arch/arm/mach-omap2/fb.c
@@ -30,6 +30,7 @@
#include <linux/dma-mapping.h>
#include <asm/mach/map.h>
+#include <asm/memblock.h>
#include "soc.h"
#include "display.h"
@@ -106,10 +107,53 @@ static struct platform_device omap_fb_device = {
.num_resources = 0,
};
+static phys_addr_t omapfb_mem_base __initdata;
+static phys_addr_t omapfb_mem_size __initdata;
+
+void __init omap_fb_reserve_memblock(void)
+{
+ if (omapfb_mem_size) {
+ omapfb_mem_base = arm_memblock_steal(omapfb_mem_size, SZ_1M);
+ if (omapfb_mem_base)
+ pr_info("omapfb: reserved %u bytes at %x\n",
+ omapfb_mem_size, omapfb_mem_base);
+ else
+ pr_err("omapfb: arm_memblock_steal failed\n");
+ }
+}
+
int __init omap_init_fb(void)
{
- return platform_device_register(&omap_fb_device);
+ int ret;
+
+ ret = platform_device_register(&omap_fb_device);
+
+ if (ret)
+ return ret;
+
+ if (!omapfb_mem_base)
+ return 0;
+
+ ret = dma_declare_coherent_memory(&omap_fb_device.dev,
+ omapfb_mem_base, omapfb_mem_base,
+ omapfb_mem_size, DMA_MEMORY_MAP |
+ DMA_MEMORY_EXCLUSIVE);
+ if (!(ret & DMA_MEMORY_MAP))
+ pr_err("omapfb: dma_declare_coherent_memory failed\n");
+
+ return 0;
+}
+
+static int __init early_omapfb_memsize(char *p)
+{
+ omapfb_mem_size = ALIGN(memparse(p, &p), SZ_1M);
+
+ if(!omapfb_mem_size)
+ pr_err("omapfb: bad memsize parameter\n");
+
+ return 0;
}
+early_param("omapfb_memsize", early_omapfb_memsize);
#else
int __init omap_init_fb(void) { return 0; }
#endif
--
1.5.6.1
next parent reply other threads:[~2013-12-25 23:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <52A062A0.3070005@ti.com>
2013-12-25 23:12 ` Ivaylo Dimitrov [this message]
2013-12-27 9:48 ` [PATCH] ARM: omapfb: Add early framebuffer memory allocator Pavel Machek
2013-12-27 16:34 ` Ivaylo Dimitrov
2015-12-25 13:36 ` Ivaylo Dimitrov
2016-01-01 12:01 ` Pali Rohár
2016-01-04 11:37 ` Tomi Valkeinen
2016-01-04 13:04 ` Ivaylo Dimitrov
2016-01-11 18:34 ` Tomi Valkeinen
2016-02-13 7:25 ` Ivaylo Dimitrov
2016-02-16 13:51 ` Tomi Valkeinen
2016-02-16 14:05 ` Pali Rohár
2016-02-17 7:31 ` Ivaylo Dimitrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388013159-3036-1-git-send-email-ivo.g.dimitrov.75@gmail.com \
--to=ivo.g.dimitrov.75@gmail.com \
--cc=freemangordon@abv.bg \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pali.rohar@gmail.com \
--cc=pavel@ucw.cz \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).