* [PATCH] ARM: OMAP3: hwmod_data: Correct clock domains for USB modules
@ 2014-04-09 15:16 Roger Quadros
2014-04-09 15:19 ` Nishanth Menon
2014-04-10 7:18 ` [PATCH v2] " Roger Quadros
0 siblings, 2 replies; 5+ messages in thread
From: Roger Quadros @ 2014-04-09 15:16 UTC (permalink / raw)
To: tony; +Cc: balbi, linux-omap, Roger Quadros, Paul Walmsley
OMAP3 doesn't contain "l3_init_clkdm" clock domain. Use the
proper clock domains for USB Host and USB TLL modules.
Gets rid of the following warnings during boot
omap_hwmod: usb_host_hs: could not associate to clkdm l3_init_clkdm
omap_hwmod: usb_tll_hs: could not associate to clkdm l3_init_clkdm
Reported-by: Nishant Menon <nm@ti.com>
CC: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
index 9c7e23a..3aa49ed 100644
--- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
@@ -1968,7 +1968,7 @@ static struct omap_hwmod_irq_info omap3xxx_usb_host_hs_irqs[] = {
static struct omap_hwmod omap3xxx_usb_host_hs_hwmod = {
.name = "usb_host_hs",
.class = &omap3xxx_usb_host_hs_hwmod_class,
- .clkdm_name = "l3_init_clkdm",
+ .clkdm_name = "usbhost_clkdm",
.mpu_irqs = omap3xxx_usb_host_hs_irqs,
.main_clk = "usbhost_48m_fck",
.prcm = {
@@ -2053,7 +2053,7 @@ static struct omap_hwmod_irq_info omap3xxx_usb_tll_hs_irqs[] = {
static struct omap_hwmod omap3xxx_usb_tll_hs_hwmod = {
.name = "usb_tll_hs",
.class = &omap3xxx_usb_tll_hs_hwmod_class,
- .clkdm_name = "l3_init_clkdm",
+ .clkdm_name = "core_l4_clkdm",
.mpu_irqs = omap3xxx_usb_tll_hs_irqs,
.main_clk = "usbtll_fck",
.prcm = {
--
1.8.3.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: OMAP3: hwmod_data: Correct clock domains for USB modules
2014-04-09 15:16 [PATCH] ARM: OMAP3: hwmod_data: Correct clock domains for USB modules Roger Quadros
@ 2014-04-09 15:19 ` Nishanth Menon
2014-04-10 7:13 ` Roger Quadros
2014-04-10 7:18 ` [PATCH v2] " Roger Quadros
1 sibling, 1 reply; 5+ messages in thread
From: Nishanth Menon @ 2014-04-09 15:19 UTC (permalink / raw)
To: Roger Quadros, tony; +Cc: balbi, linux-omap, Paul Walmsley
On 04/09/2014 10:16 AM, Roger Quadros wrote:
> OMAP3 doesn't contain "l3_init_clkdm" clock domain. Use the
> proper clock domains for USB Host and USB TLL modules.
>
> Gets rid of the following warnings during boot
> omap_hwmod: usb_host_hs: could not associate to clkdm l3_init_clkdm
> omap_hwmod: usb_tll_hs: could not associate to clkdm l3_init_clkdm
>
> Reported-by: Nishant Menon <nm@ti.com>
I guess I have a "h" at the end of my first name :P
> CC: Paul Walmsley <paul@pwsan.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> index 9c7e23a..3aa49ed 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> @@ -1968,7 +1968,7 @@ static struct omap_hwmod_irq_info omap3xxx_usb_host_hs_irqs[] = {
> static struct omap_hwmod omap3xxx_usb_host_hs_hwmod = {
> .name = "usb_host_hs",
> .class = &omap3xxx_usb_host_hs_hwmod_class,
> - .clkdm_name = "l3_init_clkdm",
> + .clkdm_name = "usbhost_clkdm",
> .mpu_irqs = omap3xxx_usb_host_hs_irqs,
> .main_clk = "usbhost_48m_fck",
> .prcm = {
> @@ -2053,7 +2053,7 @@ static struct omap_hwmod_irq_info omap3xxx_usb_tll_hs_irqs[] = {
> static struct omap_hwmod omap3xxx_usb_tll_hs_hwmod = {
> .name = "usb_tll_hs",
> .class = &omap3xxx_usb_tll_hs_hwmod_class,
> - .clkdm_name = "l3_init_clkdm",
> + .clkdm_name = "core_l4_clkdm",
> .mpu_irqs = omap3xxx_usb_tll_hs_irqs,
> .main_clk = "usbtll_fck",
> .prcm = {
>
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ARM: OMAP3: hwmod_data: Correct clock domains for USB modules
2014-04-09 15:19 ` Nishanth Menon
@ 2014-04-10 7:13 ` Roger Quadros
0 siblings, 0 replies; 5+ messages in thread
From: Roger Quadros @ 2014-04-10 7:13 UTC (permalink / raw)
To: Nishanth Menon, tony; +Cc: balbi, linux-omap, Paul Walmsley
On 04/09/2014 06:19 PM, Nishanth Menon wrote:
> On 04/09/2014 10:16 AM, Roger Quadros wrote:
>> OMAP3 doesn't contain "l3_init_clkdm" clock domain. Use the
>> proper clock domains for USB Host and USB TLL modules.
>>
>> Gets rid of the following warnings during boot
>> omap_hwmod: usb_host_hs: could not associate to clkdm l3_init_clkdm
>> omap_hwmod: usb_tll_hs: could not associate to clkdm l3_init_clkdm
>>
>> Reported-by: Nishant Menon <nm@ti.com>
>
> I guess I have a "h" at the end of my first name :P
>
Sorry Nishanth. I'll send a revised patch.
cheers,
-roger
>
>> CC: Paul Walmsley <paul@pwsan.com>
>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>> ---
>> arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
>> index 9c7e23a..3aa49ed 100644
>> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
>> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
>> @@ -1968,7 +1968,7 @@ static struct omap_hwmod_irq_info omap3xxx_usb_host_hs_irqs[] = {
>> static struct omap_hwmod omap3xxx_usb_host_hs_hwmod = {
>> .name = "usb_host_hs",
>> .class = &omap3xxx_usb_host_hs_hwmod_class,
>> - .clkdm_name = "l3_init_clkdm",
>> + .clkdm_name = "usbhost_clkdm",
>> .mpu_irqs = omap3xxx_usb_host_hs_irqs,
>> .main_clk = "usbhost_48m_fck",
>> .prcm = {
>> @@ -2053,7 +2053,7 @@ static struct omap_hwmod_irq_info omap3xxx_usb_tll_hs_irqs[] = {
>> static struct omap_hwmod omap3xxx_usb_tll_hs_hwmod = {
>> .name = "usb_tll_hs",
>> .class = &omap3xxx_usb_tll_hs_hwmod_class,
>> - .clkdm_name = "l3_init_clkdm",
>> + .clkdm_name = "core_l4_clkdm",
>> .mpu_irqs = omap3xxx_usb_tll_hs_irqs,
>> .main_clk = "usbtll_fck",
>> .prcm = {
>>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] ARM: OMAP3: hwmod_data: Correct clock domains for USB modules
2014-04-09 15:16 [PATCH] ARM: OMAP3: hwmod_data: Correct clock domains for USB modules Roger Quadros
2014-04-09 15:19 ` Nishanth Menon
@ 2014-04-10 7:18 ` Roger Quadros
2014-04-11 17:58 ` Paul Walmsley
1 sibling, 1 reply; 5+ messages in thread
From: Roger Quadros @ 2014-04-10 7:18 UTC (permalink / raw)
To: tony; +Cc: balbi, linux-omap, Roger Quadros, Paul Walmsley
OMAP3 doesn't contain "l3_init_clkdm" clock domain. Use the
proper clock domains for USB Host and USB TLL modules.
Gets rid of the following warnings during boot
omap_hwmod: usb_host_hs: could not associate to clkdm l3_init_clkdm
omap_hwmod: usb_tll_hs: could not associate to clkdm l3_init_clkdm
Reported-by: Nishanth Menon <nm@ti.com>
CC: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
v2: Corrected Nishanth's name
arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
index 9c7e23a..3aa49ed 100644
--- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
@@ -1968,7 +1968,7 @@ static struct omap_hwmod_irq_info omap3xxx_usb_host_hs_irqs[] = {
static struct omap_hwmod omap3xxx_usb_host_hs_hwmod = {
.name = "usb_host_hs",
.class = &omap3xxx_usb_host_hs_hwmod_class,
- .clkdm_name = "l3_init_clkdm",
+ .clkdm_name = "usbhost_clkdm",
.mpu_irqs = omap3xxx_usb_host_hs_irqs,
.main_clk = "usbhost_48m_fck",
.prcm = {
@@ -2053,7 +2053,7 @@ static struct omap_hwmod_irq_info omap3xxx_usb_tll_hs_irqs[] = {
static struct omap_hwmod omap3xxx_usb_tll_hs_hwmod = {
.name = "usb_tll_hs",
.class = &omap3xxx_usb_tll_hs_hwmod_class,
- .clkdm_name = "l3_init_clkdm",
+ .clkdm_name = "core_l4_clkdm",
.mpu_irqs = omap3xxx_usb_tll_hs_irqs,
.main_clk = "usbtll_fck",
.prcm = {
--
1.8.3.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] ARM: OMAP3: hwmod_data: Correct clock domains for USB modules
2014-04-10 7:18 ` [PATCH v2] " Roger Quadros
@ 2014-04-11 17:58 ` Paul Walmsley
0 siblings, 0 replies; 5+ messages in thread
From: Paul Walmsley @ 2014-04-11 17:58 UTC (permalink / raw)
To: Roger Quadros, nm
Cc: tony, Keshava Munegowda, Partha Basak, balbi, linux-omap
On Thu, 10 Apr 2014, Roger Quadros wrote:
> OMAP3 doesn't contain "l3_init_clkdm" clock domain. Use the
> proper clock domains for USB Host and USB TLL modules.
>
> Gets rid of the following warnings during boot
> omap_hwmod: usb_host_hs: could not associate to clkdm l3_init_clkdm
> omap_hwmod: usb_tll_hs: could not associate to clkdm l3_init_clkdm
>
> Reported-by: Nishanth Menon <nm@ti.com>
> CC: Paul Walmsley <paul@pwsan.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
Thanks. Looks like this was added by commit
de231388cb80a8ef3e779bbfa0564ba0157b7377 ("ARM: OMAP: USB: EHCI and OHCI
hwmod structures for OMAP3"). Have queued the following patch for
v3.15-rc.
- Paul
From: Roger Quadros <rogerq@ti.com>
Date: Thu, 10 Apr 2014 10:18:17 +0300
Subject: [PATCH] ARM: OMAP3: hwmod_data: Correct clock domains for USB modules
OMAP3 doesn't contain "l3_init_clkdm" clock domain. Use the
proper clock domains for USB Host and USB TLL modules.
Gets rid of the following warnings during boot
omap_hwmod: usb_host_hs: could not associate to clkdm l3_init_clkdm
omap_hwmod: usb_tll_hs: could not associate to clkdm l3_init_clkdm
Reported-by: Nishanth Menon <nm@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>
Signed-off-by: Roger Quadros <rogerq@ti.com>
Fixes: de231388cb80a8ef3e779bbfa0564ba0157b7377 ("ARM: OMAP: USB: EHCI and OHCI hwmod structures for OMAP3")
Cc: Keshava Munegowda <keshava_mgowda@ti.com>
Cc: Partha Basak <parthab@india.ti.com>
Signed-off-by: Paul Walmsley <paul@pwsan.com>
---
arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
index a123ff0070bd..71ac7d5f3385 100644
--- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
@@ -1964,7 +1964,7 @@ static struct omap_hwmod_irq_info omap3xxx_usb_host_hs_irqs[] = {
static struct omap_hwmod omap3xxx_usb_host_hs_hwmod = {
.name = "usb_host_hs",
.class = &omap3xxx_usb_host_hs_hwmod_class,
- .clkdm_name = "l3_init_clkdm",
+ .clkdm_name = "usbhost_clkdm",
.mpu_irqs = omap3xxx_usb_host_hs_irqs,
.main_clk = "usbhost_48m_fck",
.prcm = {
@@ -2047,7 +2047,7 @@ static struct omap_hwmod_irq_info omap3xxx_usb_tll_hs_irqs[] = {
static struct omap_hwmod omap3xxx_usb_tll_hs_hwmod = {
.name = "usb_tll_hs",
.class = &omap3xxx_usb_tll_hs_hwmod_class,
- .clkdm_name = "l3_init_clkdm",
+ .clkdm_name = "core_l4_clkdm",
.mpu_irqs = omap3xxx_usb_tll_hs_irqs,
.main_clk = "usbtll_fck",
.prcm = {
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-04-11 17:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-09 15:16 [PATCH] ARM: OMAP3: hwmod_data: Correct clock domains for USB modules Roger Quadros
2014-04-09 15:19 ` Nishanth Menon
2014-04-10 7:13 ` Roger Quadros
2014-04-10 7:18 ` [PATCH v2] " Roger Quadros
2014-04-11 17:58 ` Paul Walmsley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).