Linux on ARM based TI OMAP SoCs
 help / color / mirror / Atom feed
From: Vivek Gautam <gautam.vivek@samsung.com>
To: linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Cc: kgene.kim@samsung.com, gregkh@linuxfoundation.org,
	Jingoo Han <jg1.han@samsung.com>,
	linux-kernel@vger.kernel.org, balbi@ti.com,
	stern@rowland.harvard.edu,
	Vivek Gautam <gautam.vivek@samsung.com>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] usb: ehci-exynos: Make provision for vdd regulators
Date: Mon, 21 Apr 2014 17:46:43 +0530	[thread overview]
Message-ID: <1398082604-3013-2-git-send-email-gautam.vivek@samsung.com> (raw)
In-Reply-To: <1398082604-3013-1-git-send-email-gautam.vivek@samsung.com>

Facilitate getting required 3.3V and 1.0V VDD supply for
EHCI controller on Exynos.

With patches for regulators' nodes merged in 3.15:
c8c253f ARM: dts: Add regulator entries to smdk5420
275dcd2 ARM: dts: add max77686 pmic node for smdk5250,

certain perripherals will now need to ensure that,
they request VDD regulators in their drivers, and enable
them so as to make them working.

Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
Cc: Jingoo Han <jg1.han@samsung.com>
---

Based on 'usb-next' branch of Greg's usb tree.

 drivers/usb/host/ehci-exynos.c |   47 ++++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c
index d1d8c47..a3ca8cc 100644
--- a/drivers/usb/host/ehci-exynos.c
+++ b/drivers/usb/host/ehci-exynos.c
@@ -20,6 +20,7 @@
 #include <linux/of.h>
 #include <linux/of_gpio.h>
 #include <linux/platform_device.h>
+#include <linux/regulator/consumer.h>
 #include <linux/usb/phy.h>
 #include <linux/usb/samsung_usb_phy.h>
 #include <linux/usb.h>
@@ -46,6 +47,8 @@ struct exynos_ehci_hcd {
 	struct clk *clk;
 	struct usb_phy *phy;
 	struct usb_otg *otg;
+	struct regulator *vdd33;
+	struct regulator *vdd10;
 };
 
 #define to_exynos_ehci(hcd) (struct exynos_ehci_hcd *)(hcd_to_ehci(hcd)->priv)
@@ -112,6 +115,28 @@ static int exynos_ehci_probe(struct platform_device *pdev)
 		exynos_ehci->otg = phy->otg;
 	}
 
+	exynos_ehci->vdd33 = devm_regulator_get(&pdev->dev, "vdd33");
+	if (IS_ERR(exynos_ehci->vdd33)) {
+		err = PTR_ERR(exynos_ehci->vdd33);
+		goto fail_regulator1;
+	}
+	err = regulator_enable(exynos_ehci->vdd33);
+	if (err) {
+		dev_err(&pdev->dev, "Failed to enable VDD33 supply\n");
+		goto fail_regulator1;
+	}
+
+	exynos_ehci->vdd10 = devm_regulator_get(&pdev->dev, "vdd10");
+	if (IS_ERR(exynos_ehci->vdd10)) {
+		err = PTR_ERR(exynos_ehci->vdd10);
+		goto fail_regulator2;
+	}
+	err = regulator_enable(exynos_ehci->vdd10);
+	if (err) {
+		dev_err(&pdev->dev, "Failed to enable VDD10 supply\n");
+		goto fail_regulator2;
+	}
+
 skip_phy:
 
 	exynos_ehci->clk = devm_clk_get(&pdev->dev, "usbhost");
@@ -178,6 +203,10 @@ fail_add_hcd:
 fail_io:
 	clk_disable_unprepare(exynos_ehci->clk);
 fail_clk:
+	regulator_disable(exynos_ehci->vdd10);
+fail_regulator2:
+	regulator_disable(exynos_ehci->vdd33);
+fail_regulator1:
 	usb_put_hcd(hcd);
 	return err;
 }
@@ -197,6 +226,9 @@ static int exynos_ehci_remove(struct platform_device *pdev)
 
 	clk_disable_unprepare(exynos_ehci->clk);
 
+	regulator_disable(exynos_ehci->vdd10);
+	regulator_disable(exynos_ehci->vdd33);
+
 	usb_put_hcd(hcd);
 
 	return 0;
@@ -221,6 +253,9 @@ static int exynos_ehci_suspend(struct device *dev)
 
 	clk_disable_unprepare(exynos_ehci->clk);
 
+	regulator_disable(exynos_ehci->vdd10);
+	regulator_disable(exynos_ehci->vdd33);
+
 	return rc;
 }
 
@@ -228,6 +263,18 @@ static int exynos_ehci_resume(struct device *dev)
 {
 	struct usb_hcd *hcd = dev_get_drvdata(dev);
 	struct exynos_ehci_hcd *exynos_ehci = to_exynos_ehci(hcd);
+	int ret;
+
+	ret = regulator_enable(exynos_ehci->vdd33);
+	if (ret) {
+		dev_err(dev, "Failed to enable VDD33 supply\n");
+		return ret;
+	}
+	ret = regulator_enable(exynos_ehci->vdd10);
+	if (ret) {
+		dev_err(dev, "Failed to enable VDD10 supply\n");
+		return ret;
+	}
 
 	clk_prepare_enable(exynos_ehci->clk);
 
-- 
1.7.10.4

  reply	other threads:[~2014-04-21 12:16 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-21 12:16 [PATCH 1/3] usb: ohci-exynos: Make provision for vdd regulators Vivek Gautam
2014-04-21 12:16 ` Vivek Gautam [this message]
2014-04-23 12:44   ` [PATCH 2/3] usb: ehci-exynos: " Jingoo Han
2014-04-21 12:16 ` [PATCH 3/3] usb: dwc3-exynos: " Vivek Gautam
2014-04-23  9:26   ` Anton Tikhomirov
2014-04-23  9:51     ` Vivek Gautam
2014-04-23 10:57       ` Anton Tikhomirov
2014-04-23 11:06         ` Vivek Gautam
2014-04-23 12:31           ` Jingoo Han
2014-04-23 12:43 ` [PATCH 1/3] usb: ohci-exynos: " Jingoo Han
2014-04-24  0:18 ` Anton Tikhomirov
2014-04-24  0:32   ` Jingoo Han
2014-04-24  1:26     ` Jingoo Han
2014-04-24  6:40       ` Vivek Gautam
2014-04-24  6:57         ` Jingoo Han
2014-04-24  0:38   ` Anton Tikhomirov
2014-04-24  6:32     ` Vivek Gautam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1398082604-3013-2-git-send-email-gautam.vivek@samsung.com \
    --to=gautam.vivek@samsung.com \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jg1.han@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox