From: Joel Fernandes <joelf@ti.com>
To: Tony Lindgren <tony@atomide.com>,
Rob Herring <rob.herring@calxeda.com>,
Linux OMAP List <linux-omap@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Joel Fernandes <joelf@ti.com>
Subject: [PATCH 4/8] ARM: OMAP2+: timer: Remove hwmod look-up dependency for DT-boot
Date: Tue, 22 Apr 2014 20:27:05 -0500 [thread overview]
Message-ID: <1398216429-4681-5-git-send-email-joelf@ti.com> (raw)
In-Reply-To: <1398216429-4681-1-git-send-email-joelf@ti.com>
hwmod look ups should no longer directly happen for dmtimer users of
DT-boot platforms. We separate out the code for platforms that are
still non-DT. Ultimately this code should be deleted if all platforms
are converted to DT-boot.
We use omap_dmtimer_powerup introduced earlier in the series to abstract
out the hwmod dependency for the same. This will help us move the generic
DT specific code out into drivers/clocksource/ later.
Signed-off-by: Joel Fernandes <joelf@ti.com>
---
arch/arm/mach-omap2/timer.c | 33 +++++++++++++++++----------------
1 file changed, 17 insertions(+), 16 deletions(-)
diff --git a/arch/arm/mach-omap2/timer.c b/arch/arm/mach-omap2/timer.c
index 9fdff5b..ea91ef9 100644
--- a/arch/arm/mach-omap2/timer.c
+++ b/arch/arm/mach-omap2/timer.c
@@ -266,10 +266,6 @@ static int __init omap_dm_timer_init_one(struct omap_dm_timer *timer,
if (!np)
return -ENODEV;
- of_property_read_string_index(np, "ti,hwmods", 0, &oh_name);
- if (!oh_name)
- return -ENODEV;
-
timer->irq = irq_of_parse_and_map(np, 0);
if (!timer->irq)
return -ENXIO;
@@ -277,19 +273,24 @@ static int __init omap_dm_timer_init_one(struct omap_dm_timer *timer,
timer->io_base = of_iomap(np, 0);
of_node_put(np);
+
+ if (!timer->io_base)
+ return -ENXIO;
+
+ r = omap_dmtimer_powerup(np);
+ if (r)
+ return r;
} else {
if (omap_dm_timer_reserve_systimer(timer->id))
return -ENODEV;
sprintf(name, "timer%d", timer->id);
oh_name = name;
- }
- oh = omap_hwmod_lookup(oh_name);
- if (!oh)
- return -ENODEV;
+ oh = omap_hwmod_lookup(oh_name);
+ if (!oh)
+ return -ENODEV;
- if (!of_have_populated_dt()) {
r = omap_hwmod_get_resource_byname(oh, IORESOURCE_IRQ, NULL,
&irq);
if (r)
@@ -303,11 +304,14 @@ static int __init omap_dm_timer_init_one(struct omap_dm_timer *timer,
/* Static mapping, never released */
timer->io_base = ioremap(mem.start, mem.end - mem.start);
+
+ if (!timer->io_base)
+ return -ENXIO;
+
+
+ omap_hwmod_setup_one(oh_name);
+ omap_hwmod_enable(oh);
}
-
- if (!timer->io_base)
- return -ENXIO;
-
/* After the dmtimer is using hwmod these clocks won't be needed */
timer->fclk = clk_get(NULL, omap_hwmod_get_main_clk(oh));
if (IS_ERR(timer->fclk))
@@ -333,10 +337,7 @@ static int __init omap_dm_timer_init_one(struct omap_dm_timer *timer,
clk_put(src);
- omap_hwmod_setup_one(oh_name);
- omap_hwmod_enable(oh);
__omap_dm_timer_init_regs(timer);
-
if (posted)
__omap_dm_timer_enable_posted(timer);
--
1.7.9.5
next prev parent reply other threads:[~2014-04-23 1:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-23 1:27 [PATCH 0/8] OMAP2+ system timer cleanup series Joel Fernandes
2014-04-23 1:27 ` [PATCH 1/8] ARM: OMAP2+: timer: Add a powerup function Joel Fernandes
2014-07-21 11:00 ` Tony Lindgren
2014-04-23 1:27 ` [PATCH 2/8] ARM: OMAP2+: timer: Simplify clock event/source name setting Joel Fernandes
2014-07-21 11:05 ` Tony Lindgren
2014-04-23 1:27 ` [PATCH 3/8] ARM: OMAP2+: timer: Add comment on timer clk parenting Joel Fernandes
2014-07-21 11:07 ` Tony Lindgren
2014-04-23 1:27 ` Joel Fernandes [this message]
2014-04-23 1:27 ` [PATCH 5/8] ARM: OMAP2+: timer: Use of_clk_get for DT platforms Joel Fernandes
2014-04-23 1:27 ` [PATCH 6/8] ARM: OMAP2+: timer: Fix error message to not use hwmod structure Joel Fernandes
2014-07-21 11:09 ` Tony Lindgren
2014-04-23 1:27 ` [PATCH 7/8] ARM: OMAP2+: timer: Add fallback for of_clk_get Joel Fernandes
2014-07-21 11:10 ` Tony Lindgren
2014-04-23 1:27 ` [PATCH 8/8] ARM: OMAP2+: timer: Add legacy code for old way of getting fclk Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398216429-4681-5-git-send-email-joelf@ti.com \
--to=joelf@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox