From: Sricharan R <r.sricharan@ti.com>
To: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: nm@ti.com, rnayak@ti.com, santosh.shilimkar@ti.com, tony@atomide.com
Subject: [PATCH 1/5] irqchip: crossbar: dont use '0' to mark reserved interrupts
Date: Mon, 5 May 2014 19:48:43 +0530 [thread overview]
Message-ID: <1399299527-10955-2-git-send-email-r.sricharan@ti.com> (raw)
In-Reply-To: <1399299527-10955-1-git-send-email-r.sricharan@ti.com>
From: Nishanth Menon <nm@ti.com>
Today '0' is actually reserved, but may not be the same in the future.
So, use a flag to mark the GIC interrupts that are reserved.
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Sricharan R <r.sricharan@ti.com>
---
drivers/irqchip/irq-crossbar.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 3d15d16..20105bc 100644
--- a/drivers/irqchip/irq-crossbar.c
+++ b/drivers/irqchip/irq-crossbar.c
@@ -17,6 +17,7 @@
#include <linux/irqchip/arm-gic.h>
#define IRQ_FREE -1
+#define IRQ_RESERVED -2
#define GIC_IRQ_START 32
/*
@@ -139,7 +140,7 @@ static int __init crossbar_of_init(struct device_node *node)
pr_err("Invalid reserved entry\n");
goto err3;
}
- cb->irq_map[entry] = 0;
+ cb->irq_map[entry] = IRQ_RESERVED;
}
}
@@ -170,7 +171,7 @@ static int __init crossbar_of_init(struct device_node *node)
* reserved irqs. so find and store the offsets once.
*/
for (i = 0; i < max; i++) {
- if (!cb->irq_map[i])
+ if (cb->irq_map[i] == IRQ_RESERVED)
continue;
cb->register_offsets[i] = reserved;
--
1.7.9.5
next prev parent reply other threads:[~2014-05-05 14:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 14:18 [PATCH 0/5] irqchip/dra7: crossbar bug fixes Sricharan R
2014-05-05 14:18 ` Sricharan R [this message]
2014-05-05 14:18 ` [PATCH 2/5] irqchip: crossbar: check for premapped crossbar before allocating Sricharan R
2014-05-05 14:18 ` [PATCH 3/5] irqchip: crossbar: Skip some irqs from getting mapped to crossbar Sricharan R
2014-05-08 19:24 ` Joel Fernandes
2014-05-08 20:37 ` Nishanth Menon
2014-05-08 22:43 ` Joel Fernandes
2014-05-08 23:05 ` Santosh Shilimkar
2014-05-09 0:13 ` Joel Fernandes
2014-05-09 0:25 ` Santosh Shilimkar
2014-05-09 4:22 ` Joel Fernandes
2014-05-09 12:54 ` Nishanth Menon
2014-05-09 13:27 ` Santosh Shilimkar
2014-05-09 13:36 ` Nishanth Menon
2014-05-09 13:45 ` Santosh Shilimkar
2014-05-09 14:00 ` Nishanth Menon
2014-05-09 14:13 ` Joel Fernandes
2014-05-09 20:41 ` Santosh Shilimkar
2014-05-09 13:43 ` Joel Fernandes
2014-05-09 13:36 ` Joel Fernandes
2014-05-09 13:37 ` Joel Fernandes
2014-05-09 13:38 ` Nishanth Menon
2014-05-05 14:18 ` [PATCH 4/5] irqchip: crossbar: Initialise the crossbar with a safe value Sricharan R
2014-05-05 14:18 ` [PATCH 5/5] irqchip: crossbar: Change allocation logic by reversing search for free irqs Sricharan R
2014-05-05 18:10 ` [PATCH 0/5] irqchip/dra7: crossbar bug fixes Darren Etheridge
2014-05-06 0:48 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399299527-10955-2-git-send-email-r.sricharan@ti.com \
--to=r.sricharan@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).