From: Sricharan R <r.sricharan@ti.com>
To: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: nm@ti.com, rnayak@ti.com, santosh.shilimkar@ti.com, tony@atomide.com
Subject: [PATCH 2/5] irqchip: crossbar: check for premapped crossbar before allocating
Date: Mon, 5 May 2014 19:48:44 +0530 [thread overview]
Message-ID: <1399299527-10955-3-git-send-email-r.sricharan@ti.com> (raw)
In-Reply-To: <1399299527-10955-1-git-send-email-r.sricharan@ti.com>
From: Nishanth Menon <nm@ti.com>
If irq_of_parse_and_map is executed twice, the same crossbar is mapped to two
different GIC interrupts. This is completely undesirable. Instead, check
if the requested crossbar event is pre-allocated and provide that GIC
mapping back to caller if already allocated.
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Sricharan R <r.sricharan@ti.com>
---
drivers/irqchip/irq-crossbar.c | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/drivers/irqchip/irq-crossbar.c b/drivers/irqchip/irq-crossbar.c
index 20105bc..51d4b87 100644
--- a/drivers/irqchip/irq-crossbar.c
+++ b/drivers/irqchip/irq-crossbar.c
@@ -51,6 +51,17 @@ static inline void crossbar_writeb(int irq_no, int cb_no)
writeb(cb_no, cb->crossbar_base + cb->register_offsets[irq_no]);
}
+static inline int get_prev_map_irq(int cb_no)
+{
+ int i;
+
+ for (i = 0; i < cb->int_max; i++)
+ if (cb->irq_map[i] == cb_no)
+ return i;
+
+ return -ENODEV;
+}
+
static inline int allocate_free_irq(int cb_no)
{
int i;
@@ -88,11 +99,16 @@ static int crossbar_domain_xlate(struct irq_domain *d,
{
unsigned long ret;
+ ret = get_prev_map_irq(intspec[1]);
+ if (!IS_ERR_VALUE(ret))
+ goto found;
+
ret = allocate_free_irq(intspec[1]);
if (IS_ERR_VALUE(ret))
return ret;
+found:
*out_hwirq = ret + GIC_IRQ_START;
return 0;
}
--
1.7.9.5
next prev parent reply other threads:[~2014-05-05 14:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-05 14:18 [PATCH 0/5] irqchip/dra7: crossbar bug fixes Sricharan R
2014-05-05 14:18 ` [PATCH 1/5] irqchip: crossbar: dont use '0' to mark reserved interrupts Sricharan R
2014-05-05 14:18 ` Sricharan R [this message]
2014-05-05 14:18 ` [PATCH 3/5] irqchip: crossbar: Skip some irqs from getting mapped to crossbar Sricharan R
2014-05-08 19:24 ` Joel Fernandes
2014-05-08 20:37 ` Nishanth Menon
2014-05-08 22:43 ` Joel Fernandes
2014-05-08 23:05 ` Santosh Shilimkar
2014-05-09 0:13 ` Joel Fernandes
2014-05-09 0:25 ` Santosh Shilimkar
2014-05-09 4:22 ` Joel Fernandes
2014-05-09 12:54 ` Nishanth Menon
2014-05-09 13:27 ` Santosh Shilimkar
2014-05-09 13:36 ` Nishanth Menon
2014-05-09 13:45 ` Santosh Shilimkar
2014-05-09 14:00 ` Nishanth Menon
2014-05-09 14:13 ` Joel Fernandes
2014-05-09 20:41 ` Santosh Shilimkar
2014-05-09 13:43 ` Joel Fernandes
2014-05-09 13:36 ` Joel Fernandes
2014-05-09 13:37 ` Joel Fernandes
2014-05-09 13:38 ` Nishanth Menon
2014-05-05 14:18 ` [PATCH 4/5] irqchip: crossbar: Initialise the crossbar with a safe value Sricharan R
2014-05-05 14:18 ` [PATCH 5/5] irqchip: crossbar: Change allocation logic by reversing search for free irqs Sricharan R
2014-05-05 18:10 ` [PATCH 0/5] irqchip/dra7: crossbar bug fixes Darren Etheridge
2014-05-06 0:48 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399299527-10955-3-git-send-email-r.sricharan@ti.com \
--to=r.sricharan@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=rnayak@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).