linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Archit Taneja <archit@ti.com>
To: tomi.valkeinen@ti.com
Cc: linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org,
	Archit Taneja <archit@ti.com>
Subject: [RFC 5/6] omapdss: DPI: make dpi_get_channel take DPI reg-id
Date: Thu, 8 May 2014 14:45:16 +0530	[thread overview]
Message-ID: <1399540517-17883-5-git-send-email-archit@ti.com> (raw)
In-Reply-To: <1399540517-17883-1-git-send-email-archit@ti.com>

To support multiple DPI instances, dpi_get_channel needs to take the DPI
instance's reg-id to get the corresponding channel. Make it take this
argument.

We just pass 0 in the non-DT path, since we don't support multiple instances
in the non-DT case.

Signed-off-by: Archit Taneja <archit@ti.com>
---
 drivers/video/fbdev/omap2/dss/dpi.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/video/fbdev/omap2/dss/dpi.c b/drivers/video/fbdev/omap2/dss/dpi.c
index b891e17..faf266e 100644
--- a/drivers/video/fbdev/omap2/dss/dpi.c
+++ b/drivers/video/fbdev/omap2/dss/dpi.c
@@ -640,7 +640,7 @@ static void dpi_init_pll(struct dpi_data *dpi)
  * the channel in some more dynamic manner, or get the channel as a user
  * parameter.
  */
-static enum omap_channel dpi_get_channel(void)
+static enum omap_channel dpi_get_channel(int reg)
 {
 	switch (omapdss_get_version()) {
 	case OMAPDSS_VER_OMAP24xx:
@@ -733,7 +733,7 @@ static void dpi_init_output(struct platform_device *pdev)
 	out->id = OMAP_DSS_OUTPUT_DPI;
 	out->output_type = OMAP_DISPLAY_TYPE_DPI;
 	out->name = "dpi.0";
-	out->dispc_channel = dpi_get_channel();
+	out->dispc_channel = dpi_get_channel(0);
 	out->ops.dpi = &dpi_ops;
 	out->owner = THIS_MODULE;
 
@@ -768,7 +768,7 @@ static void dpi_init_output_port(struct platform_device *pdev,
 	out->dev = &pdev->dev;
 	out->id = OMAP_DSS_OUTPUT_DPI;
 	out->output_type = OMAP_DISPLAY_TYPE_DPI;
-	out->dispc_channel = dpi_get_channel();
+	out->dispc_channel = dpi_get_channel(reg);
 	out->ops.dpi = &dpi_ops;
 	out->reg = reg;
 	out->owner = THIS_MODULE;
-- 
1.8.3.2


  parent reply	other threads:[~2014-05-08  9:16 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-08  9:15 [RFC 1/6] omapdss: remove check for simpler port/endpoint binding Archit Taneja
2014-05-08  9:15 ` [RFC 2/6] omapdss: add init port functions for different omap revs Archit Taneja
2014-05-20  8:04   ` Tomi Valkeinen
2014-05-20  9:31     ` Archit Taneja
2014-05-08  9:15 ` [RFC 3/6] omapdss: DT: Get source endpoint by matching reg-id Archit Taneja
2014-05-08  9:15 ` [RFC 4/6] omapdss: DPI: support multiple DPI instances Archit Taneja
2014-05-08  9:15 ` Archit Taneja [this message]
2014-05-08  9:15 ` [RFC 6/6] omapdss: DSS: add reg-id param to dpi_select_source Archit Taneja
2014-05-09  9:59 ` [RFC 1/6] omapdss: remove check for simpler port/endpoint binding Tomi Valkeinen
2014-05-26  9:28 ` [RFC v2 1/5] OMAPDSS: DSS: init dss ports cleanly Archit Taneja
2014-05-26  9:28   ` [RFC v2 2/5] OMAPDSS: DT: Get source endpoint by matching reg-id Archit Taneja
2014-05-27  8:34     ` Tomi Valkeinen
2014-05-27  9:49       ` Archit Taneja
2014-05-27 10:24         ` Tomi Valkeinen
2014-05-27 10:51           ` Archit Taneja
2014-05-26  9:28   ` [RFC v2 3/5] OMAPDSS: DPI: support multiple DPI instances Archit Taneja
2014-05-27  9:04     ` Tomi Valkeinen
2014-05-27  9:27       ` Archit Taneja
2014-05-26  9:28   ` [RFC v2 4/5] OMAPDSS: DPI: make dpi_get_channel take DPI reg-id Archit Taneja
2014-05-26  9:28   ` [RFC v2 5/5] OMAPDSS: DSS: add reg-id param to dpi_select_source Archit Taneja
2014-05-27  8:24   ` [RFC v2 1/5] OMAPDSS: DSS: init dss ports cleanly Tomi Valkeinen
2014-05-27 11:42     ` Archit Taneja
2014-06-04  6:40   ` [PATCH v3 0/7] OMAPDSS: Support multiple DPI instances Archit Taneja
2014-06-04  6:40     ` [PATCH v3 1/7] OMAPDSS: DPI: Use DPI driver data Archit Taneja
2014-06-04  6:40     ` [PATCH v3 2/7] OMAPDSS: DPI: Allocate " Archit Taneja
2014-06-04  6:40     ` [PATCH v3 3/7] OMAPDSS: DPI: Store dpi_data pointer in the DT port's data Archit Taneja
2014-06-04  6:41     ` [PATCH v3 4/7] OMAPDSS: DSS: init dss ports cleanly Archit Taneja
2014-06-26 12:16       ` Tomi Valkeinen
2014-06-04  6:41     ` [PATCH v3 5/7] OMAPDSS: DT: Get source endpoint by matching reg-id Archit Taneja
2014-06-04  6:41     ` [PATCH v3 6/7] OMAPDSS: DPI: Add support for multiple instances Archit Taneja
2014-06-26 12:15       ` Tomi Valkeinen
2014-06-04  6:41     ` [PATCH v3 7/7] omapdss: DSS: add reg-id param to dpi_select_source Archit Taneja
2014-06-26 12:28     ` [PATCH v3 0/7] OMAPDSS: Support multiple DPI instances Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399540517-17883-5-git-send-email-archit@ti.com \
    --to=archit@ti.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).