From: Paul Bolle <pebolle@tiscali.nl>
To: balbi@ti.com
Cc: Tony Lindgren <tony@atomide.com>,
Russell King <linux@arm.linux.org.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: OMAP: replace checks for CONFIG_USB_GADGET_OMAP
Date: Fri, 16 May 2014 11:36:14 +0200 [thread overview]
Message-ID: <1400232974.20342.22.camel@x220> (raw)
In-Reply-To: <20140515231229.GA25523@saruman.home>
Felipe,
On Thu, 2014-05-15 at 18:12 -0500, Felipe Balbi wrote:
> On Thu, May 15, 2014 at 10:55:45PM +0200, Paul Bolle wrote:
> > diff --git a/arch/arm/mach-omap1/board-h2.c b/arch/arm/mach-omap1/board-h2.c
> > index 65d2acb31498..57092bc7f4f1 100644
> > --- a/arch/arm/mach-omap1/board-h2.c
> > +++ b/arch/arm/mach-omap1/board-h2.c
> > @@ -346,7 +346,7 @@ static struct omap_usb_config h2_usb_config __initdata = {
> > /* usb1 has a Mini-AB port and external isp1301 transceiver */
> > .otg = 2,
> >
> > -#ifdef CONFIG_USB_GADGET_OMAP
> > +#ifdef CONFIG_USB_OMAP
>
> CONFIG_USB_OMAP is tristate, it might be better to use
> IS_ENABLED(CONFIG_USB_OMAP) here. Likewise for the rest of the patch.
Will do shortly. That does increase the scope of the patch, a bit, but
since this code has been effectively dead since v3.1 that is hardly an
additional risk.
Thanks!
Paul Bolle
next prev parent reply other threads:[~2014-05-16 9:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-15 20:55 [PATCH] ARM: OMAP: replace checks for CONFIG_USB_GADGET_OMAP Paul Bolle
2014-05-15 23:12 ` Felipe Balbi
2014-05-16 9:36 ` Paul Bolle [this message]
2014-05-16 10:00 ` [PATCH v2] " Paul Bolle
2014-05-16 21:15 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1400232974.20342.22.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=balbi@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).