Re: [PATCH 07/13] Documentation: devicetree: add bindings for TI PRUSS

Mark Rutland
2014-06-30T09:34:18Z

On Sun, Jun 29, 2014 at 05:21:41PM +0100, Andre Heider wrote:
> Signed-off-by: Andre Heider <a.heider@gmail.com>
> ---
> Documentation/devicetree/bindings/misc/ti,pruss.txt | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/misc/ti,pruss.txt
>
> diff --git a/Documentation/devicetree/bindings/misc/ti,pruss.txt b/Documentation/devicetree/bindings/misc/ti,pruss.txt
> new file mode 100644
> index 0000000..4eacc41
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/misc/ti,pruss.txt
> @@ -0,0 +1,19 @@
> +TI Programmable Real-Time Unit Sub System (PRUSS)
> +
> +Required properties:
> +- compatible :
> + - "ti,pruss-v1" - for PRUv1 as found on the OMAPL138/DA850/AM18xx SoC families
> + - "ti,pruss-v2" - for PRUv2 as found on the AM33xx SoC family
> +- ti,hwmods: Name of the hwmod associated to the PRUSS
> +- reg: Address range of rtc register set
> +- interrupts: host event interrupts in order

How many of these do we expect?

> +- interrupt-parent: phandle for the interrupt controller
> +
> +Example:
> +pruss: pruss@4a300000 {
> + compatible = "ti,pruss-v2";
> + ti,hwmods = "pruss";
> + reg = <0x4a300000 0x080000>;
> + interrupts = <20 21 22 23 24 25 26 27>;

Assuming these represent more than one interrupt, could you please
bracket them individually? e.g.

interrupts = <20 21>, <22 23>, <24 25>, <26 27>;

It makes it far clearer that it's a list of multi-cell elements rather
than a giant binary blob, and usually makes it easier to read a dts.

Thanks,
Mark.