From: Joe Perches <joe@perches.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: Oliver Neukum <oneukum@suse.de>,
usb-storage@lists.one-eyed-alien.net, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return
Date: Thu, 24 Jul 2014 08:52:11 -0700 [thread overview]
Message-ID: <1406217131.27221.27.camel@joe-AO725> (raw)
In-Reply-To: <2081121229.1044862.1406216802363.open-xchange@webmail.nmp.skynet.be>
On Thu, 2014-07-24 at 17:46 +0200, Fabian Frederick wrote:
>
> > On 24 July 2014 at 13:37 Oliver Neukum <oneukum@suse.de> wrote:
> >
> >
> > On Thu, 2014-07-24 at 10:18 +0200, Fabian Frederick wrote:
> > > Small patchset addressing break redundancy on drivers/usb branch
> > > (suggested by Joe Perches).
> >
> > Frankly, that is not a good idea. Somebody will remove a "goto"
> > and forget to readd the "break"
>
> No problem ; checkpatch would give a warning anyway. See "Possible switch
> case/default not preceeded by break or fallthrough comment"
Generally true, but not everyone uses checkpatch.
prev parent reply other threads:[~2014-07-24 15:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-24 8:18 [PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return Fabian Frederick
2014-07-24 8:18 ` [PATCH 03/10 linux-next] usb: dcw3: remove unnecessary break after return Fabian Frederick
2014-07-24 11:37 ` [PATCH 00/10 linux-next] drivers/usb: remove unnecessary break after goto/return Oliver Neukum
2014-07-24 15:46 ` Fabian Frederick
2014-07-24 15:52 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406217131.27221.27.camel@joe-AO725 \
--to=joe@perches.com \
--cc=fabf@skynet.be \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.de \
--cc=usb-storage@lists.one-eyed-alien.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox