From: "Matwey V. Kornilov" <matwey.kornilov@gmail.com>
To: airlied@linux.ie
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-omap@vger.kernel.org,
"Matwey V. Kornilov" <matwey@sai.msu.ru>
Subject: [PATCHv2 2/2] gpu: drm: omapdrm: Change struct pat data_pa type to dma_addr_t
Date: Fri, 25 Jul 2014 21:37:37 +0400 [thread overview]
Message-ID: <1406309857-11141-2-git-send-email-matwey.kornilov@gmail.com> (raw)
In-Reply-To: <1406309857-11141-1-git-send-email-matwey.kornilov@gmail.com>
From: "Matwey V. Kornilov" <matwey@sai.msu.ru>
The single one use-case for data_pa member of the struct pat is to carry a value of dma_addr_t type.
This patch solves the following compilation error:
../drivers/gpu/drm/omapdrm/omap_dmm_tiler.c: In function 'dmm_txn_append':
../drivers/gpu/drm/omapdrm/omap_dmm_tiler.c:226:2: error: passing argument 3 of 'alloc_dma' from incompatible pointer type [-Werror]
data = alloc_dma(txn, 4*i, &pat->data_pa);
^
../drivers/gpu/drm/omapdrm/omap_dmm_tiler.c:77:14: note: expected 'dma_addr_t *' but argument is of type 'uint32_t *'
static void *alloc_dma(struct dmm_txn *txn, size_t sz, dma_addr_t *pa)
^
Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
---
drivers/gpu/drm/omapdrm/omap_dmm_priv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_priv.h b/drivers/gpu/drm/omapdrm/omap_dmm_priv.h
index 58bcd6a..4142525 100644
--- a/drivers/gpu/drm/omapdrm/omap_dmm_priv.h
+++ b/drivers/gpu/drm/omapdrm/omap_dmm_priv.h
@@ -105,7 +105,7 @@ struct pat {
uint32_t next_pa;
struct pat_area area;
struct pat_ctrl ctrl;
- uint32_t data_pa;
+ dma_addr_t data_pa;
};
#define DMM_FIXED_RETRY_COUNT 1000
--
1.8.1.4
prev parent reply other threads:[~2014-07-25 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 17:37 [PATCHv2 1/2] gpu: drm: omapdrm: Use %pad format for values of the dma_addr_t type Matwey V. Kornilov
2014-07-25 17:37 ` Matwey V. Kornilov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1406309857-11141-2-git-send-email-matwey.kornilov@gmail.com \
--to=matwey.kornilov@gmail.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=matwey@sai.msu.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).