From: Roger Quadros <rogerq@ti.com>
To: wg@grandegger.com, mkl@pengutronix.de
Cc: tony@atomide.com, tglx@linutronix.de, mugunthanvnm@ti.com,
george.cherian@ti.com, balbi@ti.com, nsekhar@ti.comnm@ti.com,
sergei.shtylyov@cogentembedded.com, linux-omap@vger.kernel.org,
linux-can@vger.kernel.org, netdev@vger.kernel.org,
Roger Quadros <rogerq@ti.com>
Subject: [PATCH v2 3/3] net: can: c_can: Add support for START pulse in RAMINIT sequence
Date: Tue, 9 Sep 2014 17:31:10 +0300 [thread overview]
Message-ID: <1410273070-22485-4-git-send-email-rogerq@ti.com> (raw)
In-Reply-To: <1410273070-22485-1-git-send-email-rogerq@ti.com>
Some SoCs e.g. (TI DRA7xx) need a START pulse to start the
RAMINIT sequence i.e. START bit must be set and cleared before
checking for the DONE bit status. Add a new DT property "raminit-pulse"
to specify if this mechanism must be used for RAMINIT.
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
Documentation/devicetree/bindings/net/can/c_can.txt | 3 +++
drivers/net/can/c_can/c_can.h | 1 +
drivers/net/can/c_can/c_can_platform.c | 8 ++++++++
3 files changed, 12 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/can/c_can.txt b/Documentation/devicetree/bindings/net/can/c_can.txt
index e12d1a1..705411f 100644
--- a/Documentation/devicetree/bindings/net/can/c_can.txt
+++ b/Documentation/devicetree/bindings/net/can/c_can.txt
@@ -19,6 +19,9 @@ Optional properties:
register within the syscon region
- ti,raminit-start-bit : Bit posistion of START bit in the RAMINIT register
- ti,raminit-done-bit : Bit position of DONE bit in the RAMINIT register
+- ti,raminit-pulse : Property must exist if START pulse is needed for RAMINIT
+ sequence i.e. START bit will be set and cleared before
+ checking for DONE bit.
Note: "ti,hwmods" field is used to fetch the base address and irq
resources from TI, omap hwmod data base during device registration.
diff --git a/drivers/net/can/c_can/c_can.h b/drivers/net/can/c_can/c_can.h
index bf68822..85b5ad0 100644
--- a/drivers/net/can/c_can/c_can.h
+++ b/drivers/net/can/c_can/c_can.h
@@ -175,6 +175,7 @@ struct c_can_raminit {
unsigned int reg; /* register index within syscon */
u8 start_bit; /* START bit position in raminit reg. */
u8 done_bit; /* DONE bit position in raminit reg. */
+ bool needs_pulse; /* If set, sets and clears START bit (pulse) */
};
/* c_can private data structure */
diff --git a/drivers/net/can/c_can/c_can_platform.c b/drivers/net/can/c_can/c_can_platform.c
index fb0c35b..5ae9eb3 100644
--- a/drivers/net/can/c_can/c_can_platform.c
+++ b/drivers/net/can/c_can/c_can_platform.c
@@ -120,6 +120,12 @@ static void c_can_hw_raminit_syscon(const struct c_can_priv *priv, bool enable)
ctrl |= 1 << raminit->start_bit;
regmap_write(raminit->syscon, raminit->reg, ctrl);
+ /* clear START bit if start pulse is needed */
+ if (raminit->needs_pulse) {
+ ctrl &= ~(1 << raminit->start_bit);
+ regmap_write(raminit->syscon, raminit->reg, ctrl);
+ }
+
ctrl |= 1 << raminit->done_bit;
c_can_hw_raminit_wait_syscon(priv, mask, ctrl);
}
@@ -340,6 +346,8 @@ static int c_can_plat_probe(struct platform_device *pdev)
}
priv->raminit_sys.done_bit = val;
+ priv->raminit_sys.needs_pulse = of_property_read_bool(np,
+ "ti,raminit-pulse");
priv->raminit = c_can_hw_raminit_syscon;
break;
default:
--
1.8.3.2
prev parent reply other threads:[~2014-09-09 14:31 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 14:31 [PATCH v2 0/3] net: can: Use syscon regmap for TI specific RAMINIT register Roger Quadros
2014-09-09 14:31 ` [PATCH v2 1/3] can: c_can_platform: Fix c_can_hw_raminit_ti() and add timeout Roger Quadros
2014-09-09 14:34 ` Marc Kleine-Budde
2014-09-09 14:39 ` Roger Quadros
2014-09-16 14:13 ` Marc Kleine-Budde
2014-09-09 14:34 ` Nishanth Menon
2014-09-09 14:45 ` Roger Quadros
2014-09-09 14:51 ` Nishanth Menon
2014-09-09 14:54 ` Roger Quadros
2014-09-09 14:31 ` [PATCH v2 2/3] net: can: c_can: Add syscon/regmap RAMINIT mechanism Roger Quadros
2014-09-30 13:26 ` Wolfram Sang
2014-09-30 13:33 ` Roger Quadros
2014-09-30 13:52 ` Wolfram Sang
2014-09-30 13:58 ` Roger Quadros
2014-09-30 14:19 ` Wolfram Sang
2014-09-30 14:22 ` Marc Kleine-Budde
2014-09-30 14:49 ` Wolfram Sang
2014-09-30 15:01 ` Marc Kleine-Budde
2014-09-30 15:25 ` Wolfram Sang
2014-09-30 16:04 ` Marc Kleine-Budde
2014-10-01 8:45 ` Roger Quadros
2014-10-01 8:47 ` Marc Kleine-Budde
2014-10-01 9:06 ` Roger Quadros
2014-10-01 10:01 ` Marc Kleine-Budde
2014-10-01 10:12 ` Roger Quadros
2014-10-01 10:26 ` Marc Kleine-Budde
2014-10-01 10:43 ` Wolfram Sang
2014-10-01 10:57 ` Roger Quadros
2014-10-01 11:06 ` Marc Kleine-Budde
2014-10-01 11:10 ` Wolfram Sang
2014-10-01 11:11 ` Marc Kleine-Budde
2014-09-30 13:45 ` Marc Kleine-Budde
2014-09-30 14:02 ` Roger Quadros
2014-09-30 14:11 ` Marc Kleine-Budde
2014-09-09 14:31 ` Roger Quadros [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410273070-22485-4-git-send-email-rogerq@ti.com \
--to=rogerq@ti.com \
--cc=balbi@ti.com \
--cc=george.cherian@ti.com \
--cc=mkl@pengutronix.de \
--cc=mugunthanvnm@ti.com \
--cc=nsekhar@ti.comnm \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).