From: Felipe Balbi <balbi@ti.com>
To: Russell King <linux@arm.linux.org.uk>
Cc: Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>,
Felipe Balbi <balbi@ti.com>,
Daniel Thompson <daniel.thompson@linaro.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Nicolas Pitre <nico@linaro.org>
Subject: [PATCH] arm: arm: fiq: fix build breakage with CONFIG_FIQ
Date: Wed, 17 Sep 2014 15:01:41 -0500 [thread overview]
Message-ID: <1410984101-16762-1-git-send-email-balbi@ti.com> (raw)
commit e1add97 (ARM: 8150/2: fiq: Replace default FIQ handler)
has a typo which causes build breakage whenever CONFIG_FIQ is
set.
The bug is very clear as can be noted that a new struct pt_regs
def_fiq_regs was defined but code uses dfl_fiq_regs.
Cc: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Nicolas Pitre <nico@linaro.org>
Fixes: e1add97 (ARM: 8150/2: fiq: Replace default FIQ handler)
Signed-off-by: Felipe Balbi <balbi@ti.com>
---
KernelVersion: next-20140917
Russell, let me know if this is the correct KernelVersion tag you want/need
arch/arm/kernel/fiq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/kernel/fiq.c b/arch/arm/kernel/fiq.c
index 1743049..b6ab4c7 100644
--- a/arch/arm/kernel/fiq.c
+++ b/arch/arm/kernel/fiq.c
@@ -64,7 +64,7 @@ static int fiq_def_op(void *ref, int relinquish)
if (!relinquish) {
/* Restore default handler and registers */
local_fiq_disable();
- set_fiq_regs(&dfl_fiq_regs);
+ set_fiq_regs(&def_fiq_regs);
set_fiq_handler(&no_fiq_insn, sizeof(no_fiq_insn));
local_fiq_enable();
@@ -159,6 +159,6 @@ void __init init_FIQ(int start)
{
unsigned offset = FIQ_OFFSET;
no_fiq_insn = *(unsigned long *)(0xffff0000 + offset);
- get_fiq_regs(&dfl_fiq_regs);
+ get_fiq_regs(&def_fiq_regs);
fiq_start = start;
}
--
2.1.0.243.g30d45f7
next reply other threads:[~2014-09-17 20:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-17 20:01 Felipe Balbi [this message]
2014-09-17 23:29 ` [PATCH] arm: arm: fiq: fix build breakage with CONFIG_FIQ Daniel Thompson
2014-09-18 1:51 ` Felipe Balbi
2014-09-18 13:49 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410984101-16762-1-git-send-email-balbi@ti.com \
--to=balbi@ti.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.thompson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nico@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).